From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDB8CC4320A for ; Sat, 21 Aug 2021 17:46:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF3CC611EF for ; Sat, 21 Aug 2021 17:46:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232462AbhHURqr (ORCPT ); Sat, 21 Aug 2021 13:46:47 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:34307 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229882AbhHURqp (ORCPT ); Sat, 21 Aug 2021 13:46:45 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1629567966; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=DcK/OGJk6ACbAcRkWtOSoJuwTGWJyDfcDuxnGGY8Hq8=; b=p60ikG25T/E9CtyNzORnxR+VBwVqBQCoRXQmzJUGiNPCKmWgvsgwt6Zwbet0siRJVcDHtlr0 +ObVGFzj8pHXfsQC8Hm6Vt/hJzEA7IXeEqbRZ/MlgxBC7bPi6CGOt4JPwJCkrEr+3GhaEBps 2FHmB1GK2lkEJBnibFi67rMZWcs= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 61213bdb2b9e91b688d01779 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 21 Aug 2021 17:46:03 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C9AF3C43617; Sat, 21 Aug 2021 17:46:03 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6527CC4338F; Sat, 21 Aug 2021 17:45:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 6527CC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 1/3] wilc1000: use goto labels on error path From: Kalle Valo In-Reply-To: <20210806081229.721731-2-claudiu.beznea@microchip.com> References: <20210806081229.721731-2-claudiu.beznea@microchip.com> To: Claudiu Beznea Cc: , , , , , , Claudiu Beznea User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210821174603.C9AF3C43617@smtp.codeaurora.org> Date: Sat, 21 Aug 2021 17:46:03 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Claudiu Beznea wrote: > Use goto labels on error path for probe functions. This makes code easier > to read. With this introduce also netdev_cleanup and call it where > necessary. > > Signed-off-by: Claudiu Beznea 3 patches applied to wireless-drivers-next.git, thanks. dc8b338f3bcd wilc1000: use goto labels on error path f36a0ee599c9 wilc1000: dispose irq on failure path 1d89fd1a39d1 wilc1000: use devm_clk_get_optional() -- https://patchwork.kernel.org/project/linux-wireless/patch/20210806081229.721731-2-claudiu.beznea@microchip.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches