Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net:sched fix array-index-out-of-bounds in taprio_change
@ 2021-08-11  5:10 tcs.kernel
  2021-08-11  7:44 ` Eric Dumazet
  2021-08-12 17:53 ` Jakub Kicinski
  0 siblings, 2 replies; 9+ messages in thread
From: tcs.kernel @ 2021-08-11  5:10 UTC (permalink / raw)
  To: vinicius.gomes, jhs, xiyou.wangcong, jiri, davem, kuba, netdev
  Cc: Haimin Zhang

From: Haimin Zhang <tcs_kernel@tencent.com>

syzbot report an array-index-out-of-bounds in taprio_change
index 16 is out of range for type '__u16 [16]'
that's because mqprio->num_tc is lager than TC_MAX_QUEUE,so we check
the return value of netdev_set_num_tc.

Reported-by: syzbot+2b3e5fb6c7ef285a94f6@syzkaller.appspotmail.com
Signed-off-by: Haimin Zhang <tcs_kernel@tencent.com>
---
 net/sched/sch_taprio.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index 9c79374..1ab2fc9 100644
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -1513,7 +1513,9 @@ static int taprio_change(struct Qdisc *sch, struct nlattr *opt,
 	taprio_set_picos_per_byte(dev, q);
 
 	if (mqprio) {
-		netdev_set_num_tc(dev, mqprio->num_tc);
+		err = netdev_set_num_tc(dev, mqprio->num_tc);
+		if (err)
+			goto free_sched;
 		for (i = 0; i < mqprio->num_tc; i++)
 			netdev_set_tc_queue(dev, i,
 					    mqprio->count[i],
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] net:sched fix array-index-out-of-bounds in taprio_change
@ 2021-08-11  4:09 tcs.kernel
  0 siblings, 0 replies; 9+ messages in thread
From: tcs.kernel @ 2021-08-11  4:09 UTC (permalink / raw)
  To: vinicius.gomes, jhs, xiyou.wangcong, jiri, davem, kuba, netdev
  Cc: Haimin Zhang

From: Haimin Zhang <tcs_kernel@tencent.com>

Reported-by: syzbot+2b3e5fb6c7ef285a94f6@syzkaller.appspotmail.com
Signed-off-by: Haimin Zhang <tcs_kernel@tencent.com>
---
 net/sched/sch_taprio.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index 9c79374..1ab2fc9 100644
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -1513,7 +1513,9 @@ static int taprio_change(struct Qdisc *sch, struct nlattr *opt,
 	taprio_set_picos_per_byte(dev, q);
 
 	if (mqprio) {
-		netdev_set_num_tc(dev, mqprio->num_tc);
+		err = netdev_set_num_tc(dev, mqprio->num_tc);
+		if (err)
+			goto free_sched;
 		for (i = 0; i < mqprio->num_tc; i++)
 			netdev_set_tc_queue(dev, i,
 					    mqprio->count[i],
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-08-30 16:10 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-11  5:10 [PATCH] net:sched fix array-index-out-of-bounds in taprio_change tcs.kernel
2021-08-11  7:44 ` Eric Dumazet
2021-08-11  8:30   ` Pavel Skripkin
2021-08-11  8:35     ` Pavel Skripkin
2021-08-11  8:36   ` Haimin Zhang
2021-08-30  2:09     ` Haimin Zhang
2021-08-30 16:10       ` Jakub Kicinski
2021-08-12 17:53 ` Jakub Kicinski
  -- strict thread matches above, loose matches on Subject: below --
2021-08-11  4:09 tcs.kernel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).