Netdev Archive on lore.kernel.org help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com> To: Andrew Lunn <andrew@lunn.ch>, Vivien Didelot <vivien.didelot@gmail.com>, Vladimir Oltean <olteanv@gmail.com>, "David S . Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org> Cc: "Florian Fainelli" <f.fainelli@gmail.com>, netdev@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>, stable@vger.kernel.org Subject: [PATCH net 2/2] net: dsa: b53: Set correct number of ports in the DSA struct Date: Wed, 1 Sep 2021 11:21:41 +0200 [thread overview] Message-ID: <20210901092141.6451-2-zajec5@gmail.com> (raw) In-Reply-To: <20210901092141.6451-1-zajec5@gmail.com> From: Rafał Miłecki <rafal@milecki.pl> Setting DSA_MAX_PORTS caused DSA to call b53 callbacks (e.g. b53_disable_port() during dsa_register_switch()) for invalid (non-existent) ports. That made b53 modify unrelated registers and is one of reasons for a broken BCM5301x support. This problem exists for years but DSA_MAX_PORTS usage has changed few times so it's hard to specify a single commit this change fixes. Cc: stable@vger.kernel.org Signed-off-by: Rafał Miłecki <rafal@milecki.pl> --- drivers/net/dsa/b53/b53_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index dcf9d7e5ae14..5646eb8afe38 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -2615,6 +2615,8 @@ static int b53_switch_init(struct b53_device *dev) dev->enabled_ports |= BIT(dev->cpu_port); dev->num_ports = fls(dev->enabled_ports); + dev->ds->num_ports = min_t(unsigned int, dev->num_ports, DSA_MAX_PORTS); + /* Include non standard CPU port built-in PHYs to be probed */ if (is539x(dev) || is531x5(dev)) { for (i = 0; i < dev->num_ports; i++) { @@ -2659,7 +2661,6 @@ struct b53_device *b53_switch_alloc(struct device *base, return NULL; ds->dev = base; - ds->num_ports = DSA_MAX_PORTS; dev = devm_kzalloc(base, sizeof(*dev), GFP_KERNEL); if (!dev) -- 2.26.2
next prev parent reply other threads:[~2021-09-01 9:22 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-01 9:21 [PATCH net 1/2] net: dsa: b53: Fix calculating number of switch ports Rafał Miłecki 2021-09-01 9:21 ` Rafał Miłecki [this message] 2021-09-01 17:21 ` [PATCH net 2/2] net: dsa: b53: Set correct number of ports in the DSA struct Florian Fainelli 2021-09-01 23:36 ` Jakub Kicinski 2021-09-02 1:38 ` Florian Fainelli 2021-09-01 17:16 ` [PATCH net 1/2] net: dsa: b53: Fix calculating number of switch ports Florian Fainelli 2021-09-02 8:30 ` [PATCH V2 " Rafał Miłecki 2021-09-02 8:30 ` [PATCH V2 net 2/2] net: dsa: b53: Set correct number of ports in the DSA struct Rafał Miłecki 2021-09-02 12:40 ` [PATCH V2 net 1/2] net: dsa: b53: Fix calculating number of switch ports patchwork-bot+netdevbpf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210901092141.6451-2-zajec5@gmail.com \ --to=zajec5@gmail.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=f.fainelli@gmail.com \ --cc=kuba@kernel.org \ --cc=netdev@vger.kernel.org \ --cc=olteanv@gmail.com \ --cc=rafal@milecki.pl \ --cc=stable@vger.kernel.org \ --cc=vivien.didelot@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).