Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: torvalds@linux-foundation.org, johannes@sipsolutions.net,
kuba@kernel.org
Cc: kvalo@codeaurora.org, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, miriam.rachel.korenblitz@intel.com
Subject: [PATCH] iwlwifi: mvm: add rtnl_lock() in iwl_mvm_start_get_nvm()
Date: Thu, 2 Sep 2021 13:11:01 +0300 [thread overview]
Message-ID: <20210902101101.383243-1-luca@coelho.fi> (raw)
In-Reply-To: <635201a071bb6940ac9c1f381efef6abeed13f70.camel@intel.com>
From: Luca Coelho <luciano.coelho@intel.com>
Due to a rebase damage, we lost the rtnl_lock() when the patch was
sent out. This causes an RTNL imbalance and failed assertions, due to
missing RTNL protection, for instance:
RTNL: assertion failed at net/wireless/reg.c (4025)
WARNING: CPU: 60 PID: 1720 at net/wireless/reg.c:4025 regulatory_set_wiphy_regd_sync+0x7f/0x90 [cfg80211]
Call Trace:
iwl_mvm_init_mcc+0x170/0x190 [iwlmvm]
iwl_op_mode_mvm_start+0x824/0xa60 [iwlmvm]
iwl_opmode_register+0xd0/0x130 [iwlwifi]
init_module+0x23/0x1000 [iwlmvm]
Fix this by adding the missing rtnl_lock() back to the code.
Fixes: eb09ae93dabf ("iwlwifi: mvm: load regdomain at INIT stage")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
index 6f60018feed1..77ea2d0a3091 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
@@ -686,6 +686,7 @@ static int iwl_mvm_start_get_nvm(struct iwl_mvm *mvm)
{
int ret;
+ rtnl_lock();
mutex_lock(&mvm->mutex);
ret = iwl_run_init_mvm_ucode(mvm);
--
2.33.0
next prev parent reply other threads:[~2021-09-02 10:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 20:37 [GIT PULL] Networking for v5.15 Jakub Kicinski
2021-08-31 23:56 ` pr-tracker-bot
2021-09-01 19:00 ` Linus Torvalds
2021-09-01 19:41 ` Jakub Kicinski
2021-09-01 19:49 ` Johannes Berg
2021-09-01 21:48 ` Larry Finger
2021-09-02 9:33 ` Coelho, Luciano
2021-09-02 10:11 ` Luca Coelho [this message]
2021-09-02 10:39 ` [PATCH] iwlwifi: mvm: add rtnl_lock() in iwl_mvm_start_get_nvm() David Miller
2021-09-02 15:55 ` Linus Torvalds
[not found] ` <CAP71bdV1eBm3f1qY0rfigK4VaW5icZ+hU0pw7g6fVM=hGbn7Xw@mail.gmail.com>
2021-09-02 17:16 ` [GIT PULL] Networking for v5.15 Linus Torvalds
2021-09-02 5:55 ` Larry Finger
2021-09-02 7:07 ` Johannes Berg
2021-09-02 0:02 ` John Stultz
2021-09-02 9:25 ` Dan Carpenter
2021-09-02 9:28 ` Srinivas Kandagatla
2021-09-02 10:08 ` [PATCH net] net: qrtr: revert check in qrtr_endpoint_post() Dan Carpenter
2021-09-02 10:40 ` patchwork-bot+netdevbpf
2021-09-04 3:08 ` [GIT PULL] Networking for v5.15 John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902101101.383243-1-luca@coelho.fi \
--to=luca@coelho.fi \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miriam.rachel.korenblitz@intel.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).