Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jonathan Lemon <jonathan.lemon@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, richardcochran@gmail.com,
netdev@vger.kernel.org, kernel-team@fb.com, abyagowi@fb.com
Subject: Re: [PATCH net-next 10/11] ptp: ocp: Add IRIG-B output mode control
Date: Thu, 2 Sep 2021 10:02:16 -0700 [thread overview]
Message-ID: <20210902170216.gvjwkocvoosbdkdm@bsd-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210901170700.4ad3c3fa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Wed, Sep 01, 2021 at 05:07:00PM -0700, Jakub Kicinski wrote:
> On Mon, 30 Aug 2021 16:52:35 -0700 Jonathan Lemon wrote:
> > + err = kstrtou8(buf, 0, &val);
> > + if (err)
> > + return err;
> > + if (val > 7)
> > + return -EINVAL;
> > +
> > + reg = ((val & 0x7) << 16);
> > +
> > + spin_lock_irqsave(&bp->lock, flags);
> > + iowrite32(0, &bp->irig_out->ctrl); /* disable */
> > + iowrite32(reg, &bp->irig_out->ctrl); /* change mode */
> > + iowrite32(reg | IRIG_M_CTRL_ENABLE, &bp->irig_out->ctrl);
> > + spin_unlock_irqrestore(&bp->lock, flags);
>
> locking
Not sure what you mean - all register manipulations are
already done under the lock here.
--
Jonathan
next prev parent reply other threads:[~2021-09-02 17:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 23:52 [PATCH net-next 00/11] ocp timecard updates Jonathan Lemon
2021-08-30 23:52 ` [PATCH net-next 01/11] ptp: ocp: parameterize the i2c driver used Jonathan Lemon
2021-08-30 23:52 ` [PATCH net-next 02/11] ptp: ocp: Parameterize the TOD information display Jonathan Lemon
2021-08-30 23:52 ` [PATCH net-next 03/11] ptp: ocp: Skip I2C flash read when there is no controller Jonathan Lemon
2021-08-30 23:52 ` [PATCH net-next 04/11] ptp: ocp: Skip resources with out of range irqs Jonathan Lemon
2021-08-30 23:52 ` [PATCH net-next 05/11] ptp: ocp: Add third timestamper Jonathan Lemon
2021-08-30 23:52 ` [PATCH net-next 06/11] ptp: ocp: Add SMA selector and controls Jonathan Lemon
2021-09-01 23:56 ` Jakub Kicinski
2021-09-02 16:55 ` Jonathan Lemon
2021-08-30 23:52 ` [PATCH net-next 07/11] ptp: ocp: Add IRIG-B and DCF blocks Jonathan Lemon
2021-08-30 23:52 ` [PATCH net-next 08/11] ptp: ocp: Add sysfs attribute utc_tai_offset Jonathan Lemon
2021-09-01 23:56 ` Jakub Kicinski
2021-09-02 16:57 ` Jonathan Lemon
2021-08-30 23:52 ` [PATCH net-next 09/11] ptp: ocp: Add debugfs entry for timecard Jonathan Lemon
2021-09-02 0:06 ` Jakub Kicinski
2021-09-02 17:00 ` Jonathan Lemon
2021-08-30 23:52 ` [PATCH net-next 10/11] ptp: ocp: Add IRIG-B output mode control Jonathan Lemon
2021-09-02 0:07 ` Jakub Kicinski
2021-09-02 17:02 ` Jonathan Lemon [this message]
2021-09-02 22:41 ` Jakub Kicinski
2021-08-30 23:52 ` [PATCH net-next 11/11] docs: ABI: Add sysfs documentation for timecard Jonathan Lemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902170216.gvjwkocvoosbdkdm@bsd-mbp.dhcp.thefacebook.com \
--to=jonathan.lemon@gmail.com \
--cc=abyagowi@fb.com \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).