Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
To: Marc Kleine-Budde <mkl@pengutronix.de>, linux-can@vger.kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Subject: [PATCH v3 0/2] prevent incoherent can configuration in case of early return in the CAN netlink interface
Date: Tue, 7 Sep 2021 01:03:08 +0900 [thread overview]
Message-ID: <20210906160310.54831-1-mailhol.vincent@wanadoo.fr> (raw)
This series of two patch prevents, once for all, can_priv to be in an
inconsistent state in case of an early return in can_changelink() due
to invalid parameters.
* Changelog *
v2 -> v3:
- Allocate the temporary struct can_priv on the heap instead of
declaring it as static.
- Split the patch into two to make it easier to backport to LTS
kernels and add the "Fixes" tag.
v1 -> v2:
- Change the prototype of can_calc_tdco() so that the changes are
applied to the temporary priv instead of netdev_priv(dev).
Vincent Mailhol (2):
can: netlink: prevent incoherent can configuration in case of early
return
can: bittiming: change can_calc_tdco()'s prototype to not directly
modify priv
drivers/net/can/dev/bittiming.c | 8 ++------
drivers/net/can/dev/netlink.c | 34 ++++++++++++++++++---------------
include/linux/can/bittiming.h | 7 +++++--
3 files changed, 26 insertions(+), 23 deletions(-)
--
2.32.0
next reply other threads:[~2021-09-06 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 16:03 Vincent Mailhol [this message]
2021-09-06 16:03 ` [PATCH v3 1/2] can: netlink: prevent incoherent can configuration in case of early return Vincent Mailhol
2021-09-07 2:05 ` Vincent MAILHOL
2021-09-07 12:51 ` Vincent MAILHOL
2021-09-06 16:03 ` [PATCH v3 2/2] can: bittiming: change can_calc_tdco()'s prototype to not directly modify priv Vincent Mailhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906160310.54831-1-mailhol.vincent@wanadoo.fr \
--to=mailhol.vincent@wanadoo.fr \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--subject='Re: [PATCH v3 0/2] prevent incoherent can configuration in case of early return in the CAN netlink interface' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).