Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Krzysztof Opasiak <k.opasiak@samsung.com>,
Mark Greer <mgreer@animalcreek.com>,
"David S. Miller" <davem@davemloft.net>,
linux-nfc@lists.01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 05/15] nfc: pn533: drop unneeded debug prints
Date: Tue, 7 Sep 2021 10:03:10 -0700 [thread overview]
Message-ID: <20210907100310.0cdec18b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <35626061-ff2e-cb01-21ff-87a6f776dc28@canonical.com>
On Tue, 7 Sep 2021 18:05:25 +0200 Krzysztof Kozlowski wrote:
> On 07/09/2021 14:18, Krzysztof Kozlowski wrote:
> > ftrace is a preferred and standard way to debug entering and exiting
> > functions so drop useless debug prints.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > ---
> > drivers/nfc/pn533/i2c.c | 1 -
> > drivers/nfc/pn533/pn533.c | 2 --
> > 2 files changed, 3 deletions(-)
> >
> > diff --git a/drivers/nfc/pn533/i2c.c b/drivers/nfc/pn533/i2c.c
> > index e6bf8cfe3aa7..91d4a035eb63 100644
> > --- a/drivers/nfc/pn533/i2c.c
> > +++ b/drivers/nfc/pn533/i2c.c
> > @@ -138,7 +138,6 @@ static irqreturn_t pn533_i2c_irq_thread_fn(int irq, void *data)
> > }
> >
> > client = phy->i2c_dev;
>
> This line should also be removed (reported by kbuild robot).
>
> I will send a v2.
Dave marked the series as Deferred (although this patch is Changes
Requested, I'm guessing you did that, if so please don't change patch
states in netdev pw), please hold off:
# Form letter - net-next is closed
We have already sent the networking pull request for 5.15
and therefore net-next is closed for new drivers, features,
code refactoring and optimizations. We are currently accepting
bug fixes only.
Please repost when net-next reopens after 5.15-rc1 is cut.
Look out for the announcement on the mailing list or check:
http://vger.kernel.org/~davem/net-next.html
RFC patches sent for review only are obviously welcome at any time.
next prev parent reply other threads:[~2021-09-07 17:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 12:18 [PATCH 00/15] nfc: minor printk cleanup Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 01/15] nfc: drop unneeded debug prints Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 02/15] nfc: do not break pr_debug() call into separate lines Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 03/15] nfc: nci: replace GPLv2 boilerplate with SPDX Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 04/15] nfc: fdp: drop unneeded debug prints Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 05/15] nfc: pn533: " Krzysztof Kozlowski
2021-09-07 16:05 ` Krzysztof Kozlowski
2021-09-07 17:03 ` Jakub Kicinski [this message]
2021-09-07 17:06 ` Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 06/15] nfc: pn533: use dev_err() instead of pr_err() Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 07/15] nfc: pn544: drop unneeded debug prints Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 08/15] nfc: pn544: drop unneeded memory allocation fail messages Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 09/15] nfc: s3fwrn5: simplify dereferencing pointer to struct device Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 10/15] nfc: st-nci: drop unneeded debug prints Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 11/15] nfc: st21nfca: " Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 12/15] nfc: trf7970a: " Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 13/15] nfc: microread: " Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 14/15] nfc: microread: drop unneeded memory allocation fail messages Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 15/15] nfc: mrvl: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907100310.0cdec18b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=k.opasiak@samsung.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=netdev@vger.kernel.org \
--subject='Re: [PATCH 05/15] nfc: pn533: drop unneeded debug prints' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).