Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Krzysztof Opasiak <k.opasiak@samsung.com>,
Mark Greer <mgreer@animalcreek.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-nfc@lists.01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: [PATCH 02/15] nfc: do not break pr_debug() call into separate lines
Date: Tue, 7 Sep 2021 14:18:03 +0200 [thread overview]
Message-ID: <20210907121816.37750-3-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20210907121816.37750-1-krzysztof.kozlowski@canonical.com>
Remove unneeded line break between pr_debug and arguments.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
net/nfc/hci/llc_shdlc.c | 23 +++++++++--------------
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/net/nfc/hci/llc_shdlc.c b/net/nfc/hci/llc_shdlc.c
index 78b2ceb8ae6e..e90f70385813 100644
--- a/net/nfc/hci/llc_shdlc.c
+++ b/net/nfc/hci/llc_shdlc.c
@@ -201,8 +201,7 @@ static void llc_shdlc_reset_t2(struct llc_shdlc *shdlc, int y_nr)
del_timer_sync(&shdlc->t2_timer);
shdlc->t2_active = false;
- pr_debug
- ("All sent frames acked. Stopped T2(retransmit)\n");
+ pr_debug("All sent frames acked. Stopped T2(retransmit)\n");
}
} else {
skb = skb_peek(&shdlc->ack_pending_q);
@@ -211,8 +210,7 @@ static void llc_shdlc_reset_t2(struct llc_shdlc *shdlc, int y_nr)
msecs_to_jiffies(SHDLC_T2_VALUE_MS));
shdlc->t2_active = true;
- pr_debug
- ("Start T2(retransmit) for remaining unacked sent frames\n");
+ pr_debug("Start T2(retransmit) for remaining unacked sent frames\n");
}
}
@@ -518,12 +516,11 @@ static void llc_shdlc_handle_send_queue(struct llc_shdlc *shdlc)
unsigned long time_sent;
if (shdlc->send_q.qlen)
- pr_debug
- ("sendQlen=%d ns=%d dnr=%d rnr=%s w_room=%d unackQlen=%d\n",
- shdlc->send_q.qlen, shdlc->ns, shdlc->dnr,
- shdlc->rnr == false ? "false" : "true",
- shdlc->w - llc_shdlc_w_used(shdlc->ns, shdlc->dnr),
- shdlc->ack_pending_q.qlen);
+ pr_debug("sendQlen=%d ns=%d dnr=%d rnr=%s w_room=%d unackQlen=%d\n",
+ shdlc->send_q.qlen, shdlc->ns, shdlc->dnr,
+ shdlc->rnr == false ? "false" : "true",
+ shdlc->w - llc_shdlc_w_used(shdlc->ns, shdlc->dnr),
+ shdlc->ack_pending_q.qlen);
while (shdlc->send_q.qlen && shdlc->ack_pending_q.qlen < shdlc->w &&
(shdlc->rnr == false)) {
@@ -641,8 +638,7 @@ static void llc_shdlc_sm_work(struct work_struct *work)
llc_shdlc_handle_send_queue(shdlc);
if (shdlc->t1_active && timer_pending(&shdlc->t1_timer) == 0) {
- pr_debug
- ("Handle T1(send ack) elapsed (T1 now inactive)\n");
+ pr_debug("Handle T1(send ack) elapsed (T1 now inactive)\n");
shdlc->t1_active = false;
r = llc_shdlc_send_s_frame(shdlc, S_FRAME_RR,
@@ -652,8 +648,7 @@ static void llc_shdlc_sm_work(struct work_struct *work)
}
if (shdlc->t2_active && timer_pending(&shdlc->t2_timer) == 0) {
- pr_debug
- ("Handle T2(retransmit) elapsed (T2 inactive)\n");
+ pr_debug("Handle T2(retransmit) elapsed (T2 inactive)\n");
shdlc->t2_active = false;
--
2.30.2
next prev parent reply other threads:[~2021-09-07 12:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 12:18 [PATCH 00/15] nfc: minor printk cleanup Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 01/15] nfc: drop unneeded debug prints Krzysztof Kozlowski
2021-09-07 12:18 ` Krzysztof Kozlowski [this message]
2021-09-07 12:18 ` [PATCH 03/15] nfc: nci: replace GPLv2 boilerplate with SPDX Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 04/15] nfc: fdp: drop unneeded debug prints Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 05/15] nfc: pn533: " Krzysztof Kozlowski
2021-09-07 16:05 ` Krzysztof Kozlowski
2021-09-07 17:03 ` Jakub Kicinski
2021-09-07 17:06 ` Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 06/15] nfc: pn533: use dev_err() instead of pr_err() Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 07/15] nfc: pn544: drop unneeded debug prints Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 08/15] nfc: pn544: drop unneeded memory allocation fail messages Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 09/15] nfc: s3fwrn5: simplify dereferencing pointer to struct device Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 10/15] nfc: st-nci: drop unneeded debug prints Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 11/15] nfc: st21nfca: " Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 12/15] nfc: trf7970a: " Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 13/15] nfc: microread: " Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 14/15] nfc: microread: drop unneeded memory allocation fail messages Krzysztof Kozlowski
2021-09-07 12:18 ` [PATCH 15/15] nfc: mrvl: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907121816.37750-3-krzysztof.kozlowski@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=davem@davemloft.net \
--cc=k.opasiak@samsung.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=netdev@vger.kernel.org \
--subject='Re: [PATCH 02/15] nfc: do not break pr_debug() call into separate lines' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).