Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: "Andrew Lunn" <andrew@lunn.ch>,
	"Russell King" <linux@armlinux.org.uk>,
	"Madalin Bucur" <madalin.bucur@nxp.com>,
	"Camelia Alexandra Groza (OSS)" <camelia.groza@oss.nxp.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Marek Behún" <kabel@kernel.org>, "Scott Wood" <oss@buserror.net>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/fsl/dts: Fix phy-connection-type for fm1mac3
Date: Tue, 28 Sep 2021 23:39:18 +0200	[thread overview]
Message-ID: <20210928213918.v4n3bzecbiltbktd@pali> (raw)
In-Reply-To: <20210827113836.hvqvaln65gexg5ps@pali>

On Friday 27 August 2021 13:38:36 Pali Rohár wrote:
> On Wednesday 14 July 2021 12:11:49 Scott Wood wrote:
> > On Sun, 2021-07-04 at 15:43 +0200, Pali Rohár wrote:
> > > Property phy-connection-type contains invalid value "sgmii-2500" per scheme
> > > defined in file ethernet-controller.yaml.
> > > 
> > > Correct phy-connection-type value should be "2500base-x".
> > > 
> > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > Fixes: 84e0f1c13806 ("powerpc/mpc85xx: Add MDIO bus muxing support to the
> > > board device tree(s)")
> > > ---
> > >  arch/powerpc/boot/dts/fsl/t1023rdb.dts | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> > > b/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> > > index 5ba6fbfca274..f82f85c65964 100644
> > > --- a/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> > > +++ b/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> > > @@ -154,7 +154,7 @@
> > >  
> > >                         fm1mac3: ethernet@e4000 {
> > >                                 phy-handle = <&sgmii_aqr_phy3>;
> > > -                               phy-connection-type = "sgmii-2500";
> > > +                               phy-connection-type = "2500base-x";
> > >                                 sleep = <&rcpm 0x20000000>;
> > >                         };
> > >  
> > 
> > Acked-by: Scott Wood <oss@buserror.net>
> > 
> > -Scott
> 
> Hello! If there is not any objection, could you take this patch?

Hello! I would like to remind this patch.

  reply	other threads:[~2021-09-28 21:39 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 14:34 Unsupported phy-connection-type sgmii-2500 in arch/powerpc/boot/dts/fsl/t1023rdb.dts Pali Rohár
2021-06-03 15:12 ` Andrew Lunn
2021-06-03 19:48   ` Pali Rohár
2021-06-04  7:35     ` Madalin Bucur
2021-06-04 17:32       ` Pali Rohár
2021-06-04 19:13         ` Madalin Bucur
2021-06-04 19:27       ` Russell King (Oracle)
2021-06-04 19:39         ` Madalin Bucur
2021-06-04 20:00           ` Russell King (Oracle)
2021-06-04 21:37             ` Madalin Bucur
2021-06-04 20:23           ` Andrew Lunn
2021-06-04 21:47             ` Madalin Bucur
2021-06-04 23:34               ` Pali Rohár
2021-06-05  0:33                 ` Russell King (Oracle)
2021-06-05 12:26                   ` Vladimir Oltean
2021-06-05 12:50                     ` What is inside GPON SFP module? (Was: Re: Unsupported phy-connection-type sgmii-2500 in arch/powerpc/boot/dts/fsl/t1023rdb.dts) Pali Rohár
2021-06-05 13:04                       ` Hauke Mehrtens
2021-06-05 13:31                         ` What is inside GPON SFP module? Pali Rohár
2021-06-05 14:17                           ` Hauke Mehrtens
2021-06-05 14:41                         ` What is inside GPON SFP module? (Was: Re: Unsupported phy-connection-type sgmii-2500 in arch/powerpc/boot/dts/fsl/t1023rdb.dts) Russell King (Oracle)
2021-06-08 10:33                           ` What is inside GPON SFP module? Pali Rohár
2021-06-19 20:35                 ` Unsupported phy-connection-type sgmii-2500 in arch/powerpc/boot/dts/fsl/t1023rdb.dts Pali Rohár
2021-07-04 13:43                 ` [PATCH] powerpc/fsl/dts: Fix phy-connection-type for fm1mac3 Pali Rohár
2021-07-14 17:11                   ` Scott Wood
2021-08-27 11:38                     ` Pali Rohár
2021-09-28 21:39                       ` Pali Rohár [this message]
2021-09-29 14:25                         ` Andrew Lunn
2021-10-02  9:06                           ` Pali Rohár
2021-06-04 23:18         ` Unsupported phy-connection-type sgmii-2500 in arch/powerpc/boot/dts/fsl/t1023rdb.dts Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210928213918.v4n3bzecbiltbktd@pali \
    --to=pali@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=benh@kernel.crashing.org \
    --cc=camelia.groza@oss.nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kabel@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=madalin.bucur@nxp.com \
    --cc=mpe@ellerman.id.au \
    --cc=netdev@vger.kernel.org \
    --cc=oss@buserror.net \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH] powerpc/fsl/dts: Fix phy-connection-type for fm1mac3' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).