Netdev Archive on lore.kernel.org help / color / mirror / Atom feed
From: Xuan Zhuo <xuanzhuo@linux.alibaba.com> To: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Cc: "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org> Subject: [PATCH v3 0/3] virtio support cache indirect desc Date: Fri, 29 Oct 2021 14:28:11 +0800 [thread overview] Message-ID: <20211029062814.76594-1-xuanzhuo@linux.alibaba.com> (raw) If the VIRTIO_RING_F_INDIRECT_DESC negotiation succeeds, and the number of sgs used for sending packets is greater than 1. We must constantly call __kmalloc/kfree to allocate/release desc. In the case of extremely fast package delivery, the overhead cannot be ignored: 27.46% [kernel] [k] virtqueue_add 16.66% [kernel] [k] detach_buf_split 16.51% [kernel] [k] virtnet_xsk_xmit 14.04% [kernel] [k] virtqueue_add_outbuf 5.18% [kernel] [k] __kmalloc 4.08% [kernel] [k] kfree 2.80% [kernel] [k] virtqueue_get_buf_ctx 2.22% [kernel] [k] xsk_tx_peek_desc 2.08% [kernel] [k] memset_erms 0.83% [kernel] [k] virtqueue_kick_prepare 0.76% [kernel] [k] virtnet_xsk_run 0.62% [kernel] [k] __free_old_xmit_ptr 0.60% [kernel] [k] vring_map_one_sg 0.53% [kernel] [k] native_apic_mem_write 0.46% [kernel] [k] sg_next 0.43% [kernel] [k] sg_init_table 0.41% [kernel] [k] kmalloc_slab This patch adds a cache function to virtio to cache these allocated indirect desc instead of constantly allocating and releasing desc. v3: pre-allocate per buffer indirect descriptors array v2: use struct list_head to cache the desc *** BLURB HERE *** Xuan Zhuo (3): virtio: cache indirect desc for split virtio: cache indirect desc for packed virtio-net: enable virtio desc cache drivers/net/virtio_net.c | 11 +++ drivers/virtio/virtio.c | 6 ++ drivers/virtio/virtio_ring.c | 131 ++++++++++++++++++++++++++++++----- include/linux/virtio.h | 14 ++++ 4 files changed, 145 insertions(+), 17 deletions(-) -- 2.31.0
next reply other threads:[~2021-10-29 6:28 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-29 6:28 Xuan Zhuo [this message] 2021-10-29 6:28 ` [PATCH v3 1/3] virtio: cache indirect desc for split Xuan Zhuo 2021-10-29 6:28 ` [PATCH v3 2/3] virtio: cache indirect desc for packed Xuan Zhuo 2021-10-29 6:28 ` [PATCH v3 3/3] virtio-net: enable virtio desc cache Xuan Zhuo 2022-01-06 12:28 ` [PATCH v3 0/3] virtio support cache indirect desc Michael S. Tsirkin [not found] ` <1641473339.4832802-1-xuanzhuo@linux.alibaba.com> 2022-01-10 13:50 ` Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211029062814.76594-1-xuanzhuo@linux.alibaba.com \ --to=xuanzhuo@linux.alibaba.com \ --cc=davem@davemloft.net \ --cc=jasowang@redhat.com \ --cc=kuba@kernel.org \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).