Netdev Archive on lore.kernel.org help / color / mirror / Atom feed
From: Luiz Angelo Daros de Luca <luizluca@gmail.com> To: netdev@vger.kernel.org Cc: linus.walleij@linaro.org, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, alsi@bang-olufsen.dk, arinc.unal@arinc9.com, frank-w@public-files.de, Luiz Angelo Daros de Luca <luizluca@gmail.com> Subject: [PATCH net-next v4 09/11] net: dsa: realtek: rtl8365mb: use DSA CPU port Date: Wed, 5 Jan 2022 00:15:13 -0300 [thread overview] Message-ID: <20220105031515.29276-10-luizluca@gmail.com> (raw) In-Reply-To: <20220105031515.29276-1-luizluca@gmail.com> Instead of a fixed CPU port, assume that DSA is correct. Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> Tested-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- drivers/net/dsa/realtek/rtl8365mb.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c index b22f50a9d1ef..adc72f0844ae 100644 --- a/drivers/net/dsa/realtek/rtl8365mb.c +++ b/drivers/net/dsa/realtek/rtl8365mb.c @@ -103,14 +103,13 @@ /* Chip-specific data and limits */ #define RTL8365MB_CHIP_ID_8365MB_VC 0x6367 -#define RTL8365MB_CPU_PORT_NUM_8365MB_VC 6 #define RTL8365MB_LEARN_LIMIT_MAX_8365MB_VC 2112 /* Family-specific data and limits */ #define RTL8365MB_PHYADDRMAX 7 #define RTL8365MB_NUM_PHYREGS 32 #define RTL8365MB_PHYREGMAX (RTL8365MB_NUM_PHYREGS - 1) -#define RTL8365MB_MAX_NUM_PORTS (RTL8365MB_CPU_PORT_NUM_8365MB_VC + 1) +#define RTL8365MB_MAX_NUM_PORTS 7 /* Chip identification registers */ #define RTL8365MB_CHIP_ID_REG 0x1300 @@ -1806,6 +1805,8 @@ static int rtl8365mb_reset_chip(struct realtek_priv *priv) static int rtl8365mb_setup(struct dsa_switch *ds) { struct realtek_priv *priv = ds->priv; + struct rtl8365mb_cpu cpu; + struct dsa_port *cpu_dp; struct rtl8365mb *mb; int ret; int i; @@ -1833,9 +1834,16 @@ static int rtl8365mb_setup(struct dsa_switch *ds) dev_info(priv->dev, "no interrupt support\n"); /* Configure CPU tagging */ - ret = rtl8365mb_cpu_config(priv); - if (ret) - goto out_teardown_irq; + dsa_switch_for_each_cpu_port(cpu_dp, priv->ds) { + priv->cpu_port = cpu_dp->index; + mb->cpu.mask = BIT(priv->cpu_port); + mb->cpu.trap_port = priv->cpu_port; + ret = rtl8365mb_cpu_config(priv); + if (ret) + goto out_teardown_irq; + + break; + } /* Configure ports */ for (i = 0; i < priv->num_ports; i++) { @@ -1967,8 +1975,7 @@ static int rtl8365mb_detect(struct realtek_priv *priv) "found an RTL8365MB-VC switch (ver=0x%04x)\n", chip_ver); - priv->cpu_port = RTL8365MB_CPU_PORT_NUM_8365MB_VC; - priv->num_ports = priv->cpu_port + 1; + priv->num_ports = RTL8365MB_MAX_NUM_PORTS; mb->priv = priv; mb->chip_id = chip_id; @@ -1979,8 +1986,6 @@ static int rtl8365mb_detect(struct realtek_priv *priv) mb->jam_size = ARRAY_SIZE(rtl8365mb_init_jam_8365mb_vc); mb->cpu.enable = 1; - mb->cpu.mask = BIT(priv->cpu_port); - mb->cpu.trap_port = priv->cpu_port; mb->cpu.insert = RTL8365MB_CPU_INSERT_TO_ALL; mb->cpu.position = RTL8365MB_CPU_POS_AFTER_SA; mb->cpu.rx_length = RTL8365MB_CPU_RXLEN_64BYTES; -- 2.34.0
next prev parent reply other threads:[~2022-01-05 3:16 UTC|newest] Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-05 3:15 [PATCH net-next v4 00/11] net: dsa: realtek: MDIO interface and RTL8367S Luiz Angelo Daros de Luca 2022-01-05 3:15 ` [PATCH net-next v4 01/11] net: dsa: realtek-smi: move to subdirectory Luiz Angelo Daros de Luca 2022-01-05 3:15 ` [PATCH net-next v4 02/11] net: dsa: realtek: rename realtek_smi to realtek_priv Luiz Angelo Daros de Luca 2022-01-07 3:42 ` Jakub Kicinski 2022-01-10 12:33 ` Alvin Šipraga 2022-01-16 0:04 ` Linus Walleij 2022-01-20 14:37 ` Vladimir Oltean 2022-01-05 3:15 ` [PATCH net-next v4 03/11] net: dsa: realtek: remove direct calls to realtek-smi Luiz Angelo Daros de Luca 2022-01-10 12:38 ` Alvin Šipraga 2022-01-16 0:05 ` Linus Walleij 2022-01-17 3:46 ` Florian Fainelli 2022-01-05 3:15 ` [PATCH net-next v4 04/11] net: dsa: realtek: convert subdrivers into modules Luiz Angelo Daros de Luca 2022-01-10 12:43 ` Alvin Šipraga 2022-01-17 4:02 ` Florian Fainelli 2022-01-05 3:15 ` [PATCH net-next v4 05/11] net: dsa: realtek: use phy_read in ds->ops Luiz Angelo Daros de Luca 2022-01-10 13:09 ` Alvin Šipraga 2022-01-17 4:15 ` Florian Fainelli 2022-01-18 2:55 ` Luiz Angelo Daros de Luca 2022-01-18 13:16 ` Andrew Lunn 2022-01-21 22:13 ` Luiz Angelo Daros de Luca 2022-01-21 23:48 ` Andrew Lunn 2022-01-05 3:15 ` [PATCH net-next v4 06/11] net: dsa: realtek: add new mdio interface for drivers Luiz Angelo Daros de Luca 2022-01-10 13:09 ` Alvin Šipraga 2022-01-17 4:22 ` Florian Fainelli 2022-01-18 4:38 ` Luiz Angelo Daros de Luca 2022-01-05 3:15 ` [PATCH net-next v4 07/11] net: dsa: realtek: rtl8365mb: rename extport to extint, add "realtek,ext-int" Luiz Angelo Daros de Luca 2022-01-10 13:15 ` Alvin Šipraga 2022-01-17 4:25 ` Florian Fainelli 2022-01-05 3:15 ` [PATCH net-next v4 08/11] net: dsa: realtek: rtl8365mb: use GENMASK(n-1,0) instead of BIT(n)-1 Luiz Angelo Daros de Luca 2022-01-10 13:18 ` Alvin Šipraga 2022-01-17 4:25 ` Florian Fainelli 2022-01-05 3:15 ` Luiz Angelo Daros de Luca [this message] 2022-01-07 3:37 ` [PATCH net-next v4 09/11] net: dsa: realtek: rtl8365mb: use DSA CPU port Jakub Kicinski 2022-01-10 13:22 ` Alvin Šipraga 2022-01-17 4:26 ` Florian Fainelli 2022-01-05 3:15 ` [PATCH net-next v4 10/11] net: dsa: realtek: rtl8365mb: add RTL8367S support Luiz Angelo Daros de Luca 2022-01-10 13:26 ` Alvin Šipraga 2022-01-17 4:26 ` Florian Fainelli 2022-01-05 3:15 ` [PATCH net-next v4 11/11] net: dsa: realtek: rtl8365mb: multiple cpu ports, non cpu extint Luiz Angelo Daros de Luca 2022-01-10 13:39 ` Alvin Šipraga 2022-01-10 13:53 ` Aw: " Frank Wunderlich 2022-01-11 18:17 ` Alvin Šipraga 2022-01-11 18:45 ` Aw: " Frank Wunderlich 2022-01-13 12:37 ` Alvin Šipraga 2022-01-13 15:56 ` Aw: " Frank Wunderlich 2022-01-18 4:58 ` Luiz Angelo Daros de Luca 2022-01-18 10:13 ` Alvin Šipraga 2022-01-18 13:20 ` Re: Re: " Andrew Lunn 2022-01-20 15:12 ` Vladimir Oltean 2022-01-20 23:35 ` Luiz Angelo Daros de Luca 2022-01-21 2:06 ` Vladimir Oltean 2022-01-21 3:13 ` Luiz Angelo Daros de Luca 2022-01-21 3:22 ` Florian Fainelli 2022-01-21 3:42 ` Luiz Angelo Daros de Luca 2022-01-21 3:50 ` Florian Fainelli 2022-01-21 4:37 ` Luiz Angelo Daros de Luca 2022-01-21 9:07 ` Arınç ÜNAL 2022-01-21 18:50 ` Vladimir Oltean 2022-01-21 21:51 ` Luiz Angelo Daros de Luca 2022-01-21 22:49 ` Vladimir Oltean 2022-01-22 20:12 ` Luiz Angelo Daros de Luca 2022-01-24 15:31 ` Vladimir Oltean 2022-01-24 16:46 ` Jakub Kicinski 2022-01-24 16:55 ` Vladimir Oltean 2022-01-24 17:01 ` Florian Fainelli 2022-01-24 17:21 ` Vladimir Oltean 2022-01-24 17:30 ` Florian Fainelli 2022-01-24 17:35 ` Jakub Kicinski 2022-01-24 18:20 ` Jakub Kicinski 2022-01-24 19:08 ` Vladimir Oltean 2022-01-24 19:38 ` Jakub Kicinski 2022-01-24 20:56 ` Vladimir Oltean 2022-01-24 21:42 ` Jakub Kicinski 2022-01-24 22:30 ` Vladimir Oltean 2022-01-25 7:15 ` Luiz Angelo Daros de Luca 2022-01-25 9:47 ` Vladimir Oltean 2022-01-25 22:29 ` Luiz Angelo Daros de Luca 2022-01-25 23:56 ` Florian Fainelli 2022-01-26 22:49 ` Luiz Angelo Daros de Luca 2022-01-25 9:44 ` Arınç ÜNAL 2022-01-22 15:51 ` Andrew Lunn 2022-01-30 1:54 ` Re: Re: " Luiz Angelo Daros de Luca 2022-01-30 4:42 ` Luiz Angelo Daros de Luca 2022-01-30 17:24 ` Florian Fainelli 2022-01-31 17:26 ` Luiz Angelo Daros de Luca 2022-02-01 14:46 ` Vladimir Oltean 2022-01-20 14:36 ` [PATCH net-next v4 00/11] net: dsa: realtek: MDIO interface and RTL8367S Vladimir Oltean 2022-01-20 17:46 ` Luiz Angelo Daros de Luca
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220105031515.29276-10-luizluca@gmail.com \ --to=luizluca@gmail.com \ --cc=alsi@bang-olufsen.dk \ --cc=andrew@lunn.ch \ --cc=arinc.unal@arinc9.com \ --cc=f.fainelli@gmail.com \ --cc=frank-w@public-files.de \ --cc=linus.walleij@linaro.org \ --cc=netdev@vger.kernel.org \ --cc=olteanv@gmail.com \ --cc=vivien.didelot@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).