Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Saeed Mahameed <saeed@kernel.org>
Cc: Raed Salem <raeds@nvidia.com>, <herbert@gondor.apana.org.au>,
<davem@davemloft.net>, <kuba@kernel.org>, <huyn@nvidia.com>,
<saeedm@nvidia.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 net] net/xfrm: IPsec tunnel mode fix inner_ipproto setting in sec_path
Date: Fri, 7 Jan 2022 12:03:06 +0100 [thread overview]
Message-ID: <20220107110306.GT3272477@gauss3.secunet.de> (raw)
In-Reply-To: <20220107004726.unyuuu2qki4gskxv@sx1>
On Thu, Jan 06, 2022 at 04:47:26PM -0800, Saeed Mahameed wrote:
> On Thu, Jan 06, 2022 at 10:32:23AM +0100, Steffen Klassert wrote:
> > On Mon, Jan 03, 2022 at 01:19:29PM +0200, Raed Salem wrote:
> > > The inner_ipproto saves the inner IP protocol of the plain
> > > text packet. This allows vendor's IPsec feature making offload
> > > decision at skb's features_check and configuring hardware at
> > > ndo_start_xmit, current code implenetation did not handle the
> > > case where IPsec is used in tunnel mode.
> > >
> > > Fix by handling the case when IPsec is used in tunnel mode by
> > > reading the protocol of the plain text packet IP protocol.
> > >
> > > Fixes: fa4535238fb5 ("net/xfrm: Add inner_ipproto into sec_path")
> > > Signed-off-by: Raed Salem <raeds@nvidia.com>
> >
> > Applied, thanks Raed!
>
> hmm, there are two mlx5 patches that depend on this patch, I thought Raed
> was planning to send them along with this.
>
> Steffen, is it ok if I submit those two patches to you and so you would
> send them all at once in your next net PR ?
The pull request with that patch included is already merged into
the net tree. So if you pull the net tree, you can apply the
mlx5 patches yourself. But if you prefer, I can take them too.
next prev parent reply other threads:[~2022-01-07 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 11:19 Raed Salem
2022-01-06 9:32 ` Steffen Klassert
2022-01-07 0:47 ` Saeed Mahameed
2022-01-07 11:03 ` Steffen Klassert [this message]
2022-01-10 20:20 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107110306.GT3272477@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=huyn@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=raeds@nvidia.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--subject='Re: [PATCH v2 net] net/xfrm: IPsec tunnel mode fix inner_ipproto setting in sec_path' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).