Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Melnychenko <andrew@daynix.com>
Cc: netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, davem@davemloft.net,
	jasowang@redhat.com, mst@redhat.com, yan@daynix.com,
	yuri.benditovich@daynix.com
Subject: Re: [PATCH 1/4] drivers/net/virtio_net: Fixed padded vheader to use v1 with hash.
Date: Sun, 9 Jan 2022 14:21:45 -0800	[thread overview]
Message-ID: <20220109142145.54447b38@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20220109210659.2866740-2-andrew@daynix.com>

On Sun,  9 Jan 2022 23:06:56 +0200 Andrew Melnychenko wrote:
> The header v1 provides additional info about RSS.
> Added changes to computing proper header length.
> In the next patches, the header may contain RSS hash info
> for the hash population.
> 
> Signed-off-by: Andrew Melnychenko <andrew@daynix.com>

You can't break build in between patches:

drivers/net/virtio_net.c: In function ‘page_to_skb’:
drivers/net/virtio_net.c:398:15: error: ‘struct virtnet_info’ has no member named ‘has_rss_hash_report’
  398 |         if (vi->has_rss_hash_report)
      |               ^~

  reply	other threads:[~2022-01-09 22:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-09 21:06 [PATCH 0/4] RSS support for VirtioNet Andrew Melnychenko
2022-01-09 21:06 ` [PATCH 1/4] drivers/net/virtio_net: Fixed padded vheader to use v1 with hash Andrew Melnychenko
2022-01-09 22:21   ` Jakub Kicinski [this message]
2022-01-09 21:06 ` [PATCH 2/4] drivers/net/virtio_net: Added basic RSS support Andrew Melnychenko
2022-01-11  3:44   ` Jason Wang
2022-01-11 12:00   ` Michael S. Tsirkin
2022-01-17  7:49     ` Andrew Melnichenko
2022-01-09 21:06 ` [PATCH 3/4] drivers/net/virtio_net: Added RSS hash report Andrew Melnychenko
2022-01-11  4:05   ` Jason Wang
2022-01-17  7:57     ` Andrew Melnichenko
2022-01-09 21:06 ` [PATCH 4/4] drivers/net/virtio_net: Added RSS hash report control Andrew Melnychenko
2022-01-11  4:32   ` Jason Wang
2022-01-17  7:58     ` Andrew Melnichenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220109142145.54447b38@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
    --to=kuba@kernel.org \
    --cc=andrew@daynix.com \
    --cc=davem@davemloft.net \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=yan@daynix.com \
    --cc=yuri.benditovich@daynix.com \
    --subject='Re: [PATCH 1/4] drivers/net/virtio_net: Fixed padded vheader to use v1 with hash.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).