Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Melnychenko <andrew@daynix.com>
To: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
kuba@kernel.org, jasowang@redhat.com, mst@redhat.com
Cc: yan@daynix.com, yuri.benditovich@daynix.com
Subject: [PATCH 1/4] drivers/net/virtio_net: Fixed padded vheader to use v1 with hash.
Date: Sun, 9 Jan 2022 23:06:56 +0200 [thread overview]
Message-ID: <20220109210659.2866740-2-andrew@daynix.com> (raw)
In-Reply-To: <20220109210659.2866740-1-andrew@daynix.com>
The header v1 provides additional info about RSS.
Added changes to computing proper header length.
In the next patches, the header may contain RSS hash info
for the hash population.
Signed-off-by: Andrew Melnychenko <andrew@daynix.com>
---
drivers/net/virtio_net.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index b107835242ad..66439ca488f4 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -242,13 +242,13 @@ struct virtnet_info {
};
struct padded_vnet_hdr {
- struct virtio_net_hdr_mrg_rxbuf hdr;
+ struct virtio_net_hdr_v1_hash hdr;
/*
* hdr is in a separate sg buffer, and data sg buffer shares same page
* with this header sg. This padding makes next sg 16 byte aligned
* after the header.
*/
- char padding[4];
+ char padding[12];
};
static bool is_xdp_frame(void *ptr)
@@ -395,7 +395,9 @@ static struct sk_buff *page_to_skb(struct virtnet_info *vi,
hdr_p = p;
hdr_len = vi->hdr_len;
- if (vi->mergeable_rx_bufs)
+ if (vi->has_rss_hash_report)
+ hdr_padded_len = sizeof(struct virtio_net_hdr_v1_hash);
+ else if (vi->mergeable_rx_bufs)
hdr_padded_len = sizeof(*hdr);
else
hdr_padded_len = sizeof(struct padded_vnet_hdr);
@@ -1266,7 +1268,8 @@ static unsigned int get_mergeable_buf_len(struct receive_queue *rq,
struct ewma_pkt_len *avg_pkt_len,
unsigned int room)
{
- const size_t hdr_len = sizeof(struct virtio_net_hdr_mrg_rxbuf);
+ struct virtnet_info *vi = rq->vq->vdev->priv;
+ const size_t hdr_len = vi->hdr_len;
unsigned int len;
if (room)
@@ -2849,7 +2852,7 @@ static void virtnet_del_vqs(struct virtnet_info *vi)
*/
static unsigned int mergeable_min_buf_len(struct virtnet_info *vi, struct virtqueue *vq)
{
- const unsigned int hdr_len = sizeof(struct virtio_net_hdr_mrg_rxbuf);
+ const unsigned int hdr_len = vi->hdr_len;
unsigned int rq_size = virtqueue_get_vring_size(vq);
unsigned int packet_len = vi->big_packets ? IP_MAX_MTU : vi->dev->max_mtu;
unsigned int buf_len = hdr_len + ETH_HLEN + VLAN_HLEN + packet_len;
--
2.34.1
next prev parent reply other threads:[~2022-01-09 21:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 21:06 [PATCH 0/4] RSS support for VirtioNet Andrew Melnychenko
2022-01-09 21:06 ` Andrew Melnychenko [this message]
2022-01-09 22:21 ` [PATCH 1/4] drivers/net/virtio_net: Fixed padded vheader to use v1 with hash Jakub Kicinski
2022-01-09 21:06 ` [PATCH 2/4] drivers/net/virtio_net: Added basic RSS support Andrew Melnychenko
2022-01-11 3:44 ` Jason Wang
2022-01-11 12:00 ` Michael S. Tsirkin
2022-01-17 7:49 ` Andrew Melnichenko
2022-01-09 21:06 ` [PATCH 3/4] drivers/net/virtio_net: Added RSS hash report Andrew Melnychenko
2022-01-11 4:05 ` Jason Wang
2022-01-17 7:57 ` Andrew Melnichenko
2022-01-09 21:06 ` [PATCH 4/4] drivers/net/virtio_net: Added RSS hash report control Andrew Melnychenko
2022-01-11 4:32 ` Jason Wang
2022-01-17 7:58 ` Andrew Melnichenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220109210659.2866740-2-andrew@daynix.com \
--to=andrew@daynix.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=yan@daynix.com \
--cc=yuri.benditovich@daynix.com \
--subject='Re: [PATCH 1/4] drivers/net/virtio_net: Fixed padded vheader to use v1 with hash.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).