Netdev Archive on
help / color / mirror / Atom feed
From: Jakub Kicinski <>
To: Linus Torvalds <>
Cc: David Miller <>,
	Netdev <>,
	Linux Kernel Mailing List <>
Subject: Re: [GIT PULL] Networking for 5.17
Date: Mon, 10 Jan 2022 20:56:03 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, 10 Jan 2022 19:31:30 -0800 Linus Torvalds wrote:
> >   git:// tags/5.17-net-next  
> Merged. But I now note that this actually triggers an error when
> building with clang:
>   net/netfilter/nf_tables_api.c:8278:4: error: variable 'data_size' is
> uninitialized when used here [-Werror,-Wuninitialized]
>                           data_size += sizeof(*prule) + rule->dlen;
>                           ^~~~~~~~~
> and I think clang is entirely right.
> Sadly, I didn't actually notice that before having done the merge, so
> I'll have to do the fixup as a separate commit.

Damn it :/ Sorry.
> I really wish we had more automation doing clang builds. Yes, some
> parts of the kernel are still broken with clang, but a lot isn't, and
> this isn't the first time my clang build setup has found issues.

We have clang W=1 running on patchwork but the PR this came thru didn't
register right. I'll build test with clang going forward.

> I also notice that NET_VENDOR_VERTEXCOM defaults to 'n'. That's fine
> by me, but it seems unusual. Normally the 'enable vendor XYZ' tend to
> default to 'y'. But for unusual (and new) vendors, maybe that 'n' is
> the right thing to avoid unnecessary questions.
> And maybe that NET_VENDOR_xyz thing has happened many times before,
> and I just haven't happened to notice...

There is a patch posted to flip it back to 'y' already, I didn't think
it was worth waiting for. That said I don't actually know why vendors
default to y. The only explanation I can come up with it's that it was
done so that people running olddefconfig right after the per-vendor
split was introduced wouldn't lose all drivers. We'll fix vertexcom
for consistency but may flip all the vendors' default to 'n' for 
the next merge window.

  parent reply	other threads:[~2022-01-11  4:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10  2:52 Jakub Kicinski
2022-01-11  3:20 ` pr-tracker-bot
2022-01-11  3:31 ` Linus Torvalds
2022-01-11  3:42   ` Linus Torvalds
2022-01-11  4:56   ` Jakub Kicinski [this message]
2022-01-11  5:02     ` Linus Torvalds
2022-01-11 16:01   ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [GIT PULL] Networking for 5.17' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).