Netdev Archive on
help / color / mirror / Atom feed
From: Jakub Kicinski <>
To: Pablo Neira Ayuso <>
Subject: Re: [PATCH net-next] netfilter: nf_tables: fix compile warnings
Date: Mon, 10 Jan 2022 20:57:55 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, 10 Jan 2022 23:14:19 +0100 Pablo Neira Ayuso wrote:
> Remove unused variable and fix missing initialization.
> >> net/netfilter/nf_tables_api.c:8266:6: warning: variable 'i' set but not used [-Wunused-but-set-variable]  
>            int i;
>                ^
> >> net/netfilter/nf_tables_api.c:8277:4: warning: variable 'data_size' is uninitialized when used here [-Wuninitialized]  
>                            data_size += sizeof(*prule) + rule->dlen;
>                            ^~~~~~~~~
>    net/netfilter/nf_tables_api.c:8262:30: note: initialize the variable 'data_size' to silence this warning
>            unsigned int size, data_size;
> Fixes: 2c865a8a28a1 ("netfilter: nf_tables: add rule blob layout")
> Reported-by: kernel test robot <>
> Signed-off-by: Pablo Neira Ayuso <>
> ---
> Please, directly apply to net-next, thanks. Otherwise let me know and
> I'll prepare a pull request with pending fixes once net-next gets merged
> into net.

As you have probably seen Linus fixed this up himself.

You can take the fix for the other warning thru your tree.

  reply	other threads:[~2022-01-11  4:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10 22:14 Pablo Neira Ayuso
2022-01-11  4:57 ` Jakub Kicinski [this message]
2022-01-11  9:32   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH net-next] netfilter: nf_tables: fix compile warnings' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).