Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Matthew Wilcox <willy@infradead.org>,
linux-kernel@vger.kernel.org,
Joao Martins <joao.m.martins@oracle.com>,
John Hubbard <jhubbard@nvidia.com>,
Logan Gunthorpe <logang@deltatee.com>,
Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, netdev@vger.kernel.org,
linux-mm@kvack.org, linux-rdma@vger.kernel.org,
dri-devel@lists.freedesktop.org, nvdimm@lists.linux.dev
Subject: Re: Phyr Starter
Date: Thu, 20 Jan 2022 13:17:23 -0400 [thread overview]
Message-ID: <20220120171723.GT84788@nvidia.com> (raw)
In-Reply-To: <20220120140340.GC11223@lst.de>
On Thu, Jan 20, 2022 at 03:03:40PM +0100, Christoph Hellwig wrote:
> On Wed, Jan 12, 2022 at 06:37:03PM +0000, Matthew Wilcox wrote:
> > But let's go further than that (which only brings us to 32 bytes per
> > range). For the systems you care about which use an identity mapping,
> > and have sizeof(dma_addr_t) == sizeof(phys_addr_t), we can simply
> > point the dma_range pointer to the same memory as the phyr. We just
> > have to not free it too early. That gets us down to 16 bytes per range,
> > a saving of 33%.
>
> Even without an IOMMU the dma_addr_t can have offsets vs the actual
> physical address. Not on x86 except for a weirdo SOC, but just about
> everywhere else.
The point is dma_map knows if that is happening or not and giving
dma_map the option to just return a pointer to the input memory to
re-use as the dma list does optimize important widely used cases.
Yes, some weirdo SOC cannot do this optimization, but the weirdo SOC
will allocate a new memory and return the adjusted dma_addr_t just
fine.
Ideally we should not pay a cost for weirdo SOC on sane systems.
Jason
next prev parent reply other threads:[~2022-01-20 17:17 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 19:34 Matthew Wilcox
2022-01-11 0:41 ` Jason Gunthorpe
2022-01-11 4:32 ` Matthew Wilcox
2022-01-11 15:01 ` Jason Gunthorpe
2022-01-11 18:33 ` Matthew Wilcox
2022-01-11 20:21 ` Jason Gunthorpe
2022-01-11 21:25 ` Matthew Wilcox
2022-01-11 22:09 ` Logan Gunthorpe
2022-01-11 22:57 ` Jason Gunthorpe
2022-01-11 23:02 ` Logan Gunthorpe
2022-01-11 22:53 ` Jason Gunthorpe
2022-01-11 22:57 ` Logan Gunthorpe
2022-01-11 23:02 ` Jason Gunthorpe
2022-01-11 23:08 ` Logan Gunthorpe
2022-01-12 18:37 ` Matthew Wilcox
2022-01-12 19:08 ` Jason Gunthorpe
2022-01-20 14:03 ` Christoph Hellwig
2022-01-20 17:17 ` Jason Gunthorpe [this message]
2022-01-20 14:00 ` Christoph Hellwig
2022-01-11 9:05 ` Daniel Vetter
2022-01-11 20:26 ` Jason Gunthorpe
2022-01-20 14:09 ` Christoph Hellwig
2022-01-20 13:56 ` Christoph Hellwig
2022-01-20 15:27 ` Keith Busch
2022-01-20 15:28 ` Christoph Hellwig
2022-01-20 17:54 ` Robin Murphy
2022-01-11 8:17 ` John Hubbard
2022-01-11 14:01 ` Matthew Wilcox
2022-01-11 15:02 ` Jason Gunthorpe
2022-01-11 17:31 ` Logan Gunthorpe
2022-01-20 14:12 ` Christoph Hellwig
2022-01-20 21:35 ` John Hubbard
2022-01-11 11:40 ` Thomas Zimmermann
2022-01-11 13:56 ` Matthew Wilcox
2022-01-11 14:10 ` Thomas Zimmermann
2022-01-20 13:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220120171723.GT84788@nvidia.com \
--to=jgg@nvidia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=jhubbard@nvidia.com \
--cc=joao.m.martins@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=ming.lei@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=willy@infradead.org \
--subject='Re: Phyr Starter' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).