Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sasha Neftin <sasha.neftin@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
	<kuba@kernel.org>, <netdev@vger.kernel.org>,
	<vitaly.lifshits@intel.com>,
	Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
Subject: Re: [PATCH net-next 09/12] igc: Remove _I_PHY_ID checking
Date: Thu, 22 Jul 2021 08:22:15 +0300	[thread overview]
Message-ID: <2866eff1-cf02-9d07-e424-23e7ab96a99a@intel.com> (raw)
In-Reply-To: <YPh7KTyNQScVjp13@lunn.ch>

On 7/21/2021 22:53, Andrew Lunn wrote:
> On Wed, Jul 21, 2021 at 09:02:13PM +0300, Sasha Neftin wrote:
>> On 7/21/2021 17:50, Andrew Lunn wrote:
>>> On Tue, Jul 20, 2021 at 04:20:58PM -0700, Tony Nguyen wrote:
>>>> From: Sasha Neftin <sasha.neftin@intel.com>
>>>>
>>>> i225 devices have only one PHY vendor. There is no point checking
>>>> _I_PHY_ID during the link establishment and auto-negotiation process.
>>>> This patch comes to clean up these pointless checkings.
>>>
>>> I don't know this hardware....
>>>
>>> Is the PHY integrated into the MAC? Or is it external?
>> i225 controller offers a fully-integrated Media Access Control
>> (MAC) and Physical Layer (PHY) port.
>> Both components (MAC and PHY) supports 2.5G
> 
> Hi Sasha
> 
> Thanks for the info. Then this change make sense. But the commit
> message could of been better. It is not really about there being one
> PHY vendor, it is simply impossible for the PHY to be anything else,
> so there is no need to check.
We will clarify it in the commit message.
> 
> 	Andrew
> 
Sasha Neftin

  reply	other threads:[~2021-07-22  5:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 23:20 [PATCH net-next 00/12][pull request] 1GbE Intel Wired LAN Driver Updates 2021-07-20 Tony Nguyen
2021-07-20 23:20 ` [PATCH net-next 01/12] e1000e: Add handshake with the CSME to support S0ix Tony Nguyen
2021-07-20 23:20 ` [PATCH net-next 02/12] e1000e: Add polling mechanism to indicate CSME DPG exit Tony Nguyen
2021-07-20 23:20 ` [PATCH net-next 03/12] e1000e: Additional PHY power saving in S0ix Tony Nguyen
2021-07-20 23:20 ` [PATCH net-next 04/12] e1000e: Add support for Lunar Lake Tony Nguyen
2021-07-20 23:20 ` [PATCH net-next 05/12] e1000e: Add support for the next LOM generation Tony Nguyen
2021-07-20 23:20 ` [PATCH net-next 06/12] e1000e: Add space to the debug print Tony Nguyen
2021-07-20 23:20 ` [PATCH net-next 07/12] net/e1000e: Fix spelling mistake "The" -> "This" Tony Nguyen
2021-07-20 23:20 ` [PATCH net-next 08/12] igc: Check if num of q_vectors is smaller than max before array access Tony Nguyen
2021-07-20 23:20 ` [PATCH net-next 09/12] igc: Remove _I_PHY_ID checking Tony Nguyen
2021-07-21 14:50   ` Andrew Lunn
2021-07-21 18:02     ` Sasha Neftin
2021-07-21 19:53       ` Andrew Lunn
2021-07-22  5:22         ` Sasha Neftin [this message]
2021-07-20 23:20 ` [PATCH net-next 10/12] igc: Remove phy->type checking Tony Nguyen
2021-07-20 23:21 ` [PATCH net-next 11/12] igc: Set QBVCYCLET_S to 0 for TSN Basic Scheduling Tony Nguyen
2021-07-20 23:21 ` [PATCH net-next 12/12] igc: Increase timeout value for Speed 100/1000/2500 Tony Nguyen
2021-07-21  0:00 ` [PATCH net-next 00/12][pull request] 1GbE Intel Wired LAN Driver Updates 2021-07-20 patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2866eff1-cf02-9d07-e424-23e7ab96a99a@intel.com \
    --to=sasha.neftin@intel.com \
    --cc=andrew@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=dvorax.fuxbrumer@linux.intel.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vitaly.lifshits@intel.com \
    --subject='Re: [PATCH net-next 09/12] igc: Remove _I_PHY_ID checking' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).