Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, jiri@mellanox.com, kuba@kernel.org,
	corbet@lwn.net, michael.chan@broadcom.com, luobin9@huawei.com,
	saeedm@mellanox.com, leon@kernel.org, idosch@mellanox.com,
	danieller@mellanox.com
Subject: Re: [net-next v3 1/4] devlink: check flash_update parameter support in net core
Date: Wed, 19 Aug 2020 17:58:43 -0700	[thread overview]
Message-ID: <2eb17b37-3bb2-12ac-2ea5-956537e45e45@intel.com> (raw)
In-Reply-To: <20200819.163610.793690736242734635.davem@davemloft.net>



On 8/19/2020 4:36 PM, David Miller wrote:
> From: Jacob Keller <jacob.e.keller@intel.com>
> Date: Tue, 18 Aug 2020 17:28:15 -0700
> 
>> @@ -991,6 +993,12 @@ enum devlink_trap_group_generic_id {
>>  	}
>>  
>>  struct devlink_ops {
>> +	/**
>> +	 * @supported_flash_update_params:
>> +	 * mask of parameters supported by the driver's .flash_update
>> +	 * implemementation.
>> +	 */
>> +	u32 supported_flash_update_params;
>>  	int (*reload_down)(struct devlink *devlink, bool netns_change,
>>  			   struct netlink_ext_ack *extack);
>>  	int (*reload_up)(struct devlink *devlink,
> 
> Jakub asked if this gave W=1 warnings.  Then you responded that you didn't
> see any warnings with allmodconfig nor allyesconfig, but that isn't the
> question Jakub asked.
> 

Ah, yes I should have been more specific:

> Are you building with W=1 explicitly added to the build?
>

I did

$ make allyesconfig
$ make W=1 &>allyes.txt
$ cat allyes.txt | grep warning | grep devlink
drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:917: warning: Function
parameter or member 'devlink' not described in 'hinic_init_hwdev'



and
$ make allmodconfig
$ make W=1 *>allmod.txt
$ cat allyes.txt | grep warning | grep devlink
drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:917: warning: Function
parameter or member 'devlink' not described in 'hinic_init_hwdev'
I also looked at those manually, there's about 15k warnings with W=1 on
allyesconfig, but none of them appear to be related to the changes in
this patch.

> The issue is this kerneldoc might not be formatted correctly, and such
> warnings won't be presented without doing a W=1 build.
> 
> Thank you.
> 

Sure.

I also manually ran:

$ ./scripts/kernel-doc -v -none include/uapi/linux/devlink.h
include/uapi/linux/devlink.h:232: info: Scanning doc for enum
devlink_trap_action
include/uapi/linux/devlink.h:246: info: Scanning doc for enum
devlink_trap_type

Hope this helps clarify.

Thanks,
Jake

  reply	other threads:[~2020-08-20  0:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19  0:28 [net-next v3 0/4] devlink flash update overwrite mask Jacob Keller
2020-08-19  0:28 ` [net-next v3 1/4] devlink: check flash_update parameter support in net core Jacob Keller
2020-08-19  3:45   ` Jakub Kicinski
2020-08-19 15:53     ` Keller, Jacob E
2020-08-19 23:36   ` David Miller
2020-08-20  0:58     ` Jacob Keller [this message]
2020-08-19  0:28 ` [net-next v3 2/4] devlink: convert flash_update to use params structure Jacob Keller
2020-08-19  0:28 ` [net-next v3 3/4] devlink: introduce flash update overwrite mask Jacob Keller
2020-08-19  3:54   ` Jakub Kicinski
2020-08-19 16:01     ` Keller, Jacob E
2020-08-19 16:30       ` Jakub Kicinski
2020-08-19 17:06         ` Keller, Jacob E
2020-08-19  0:28 ` [net-next v3 4/4] ice: add support for " Jacob Keller
2020-08-19  0:28 ` [iproute2-next v3 0/2] devlink " Jacob Keller
2020-08-19  0:28 ` [iproute2-next v3 1/2] Update devlink header for overwrite mask attribute Jacob Keller
2020-08-19  0:28 ` [iproute2-next v3 2/2] devlink: support setting the overwrite mask Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2eb17b37-3bb2-12ac-2ea5-956537e45e45@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=corbet@lwn.net \
    --cc=danieller@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=idosch@mellanox.com \
    --cc=jiri@mellanox.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=luobin9@huawei.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    --subject='Re: [net-next v3 1/4] devlink: check flash_update parameter support in net core' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).