Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [V2][PATCH] atm: horizon: Fix spelling mistakes in TX comment
@ 2021-08-07 15:38 Jun Miao
  2021-08-07 16:58 ` Joe Perches
  0 siblings, 1 reply; 5+ messages in thread
From: Jun Miao @ 2021-08-07 15:38 UTC (permalink / raw)
  To: 3chas3; +Cc: linux-atm-general, netdev, linux-kernel, jun.miao

It's "must not", not "musn't", meaning "shall not".
Let's fix that.

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Jun Miao <jun.miao@windriver.com>
---
 drivers/atm/horizon.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
index 4f2951cbe69c..9ee494bc5c51 100644
--- a/drivers/atm/horizon.c
+++ b/drivers/atm/horizon.c
@@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc)
   
   // Part of the job is done by atm_pcr_goal which gives us a PCR
   // specification which says: EITHER grab the maximum available PCR
-  // (and perhaps a lower bound which we musn't pass), OR grab this
+  // (and perhaps a lower bound which we mustn't pass), OR grab this
   // amount, rounding down if you have to (and perhaps a lower bound
-  // which we musn't pass) OR grab this amount, rounding up if you
-  // have to (and perhaps an upper bound which we musn't pass). If any
+  // which we mustn't pass) OR grab this amount, rounding up if you
+  // have to (and perhaps an upper bound which we mustn't pass). If any
   // bounds ARE passed we fail. Note that rounding is only rounding to
   // match device limitations, we do not round down to satisfy
   // bandwidth availability even if this would not violate any given
-- 
2.32.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [V2][PATCH] atm: horizon: Fix spelling mistakes in TX comment
  2021-08-07 15:38 [V2][PATCH] atm: horizon: Fix spelling mistakes in TX comment Jun Miao
@ 2021-08-07 16:58 ` Joe Perches
  2021-08-07 23:33   ` Jun Miao
  0 siblings, 1 reply; 5+ messages in thread
From: Joe Perches @ 2021-08-07 16:58 UTC (permalink / raw)
  To: Jun Miao, 3chas3; +Cc: linux-atm-general, netdev, linux-kernel

On Sat, 2021-08-07 at 23:38 +0800, Jun Miao wrote:
> It's "must not", not "musn't", meaning "shall not".
> Let's fix that.
> 
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Jun Miao <jun.miao@windriver.com>
> ---
>  drivers/atm/horizon.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
> index 4f2951cbe69c..9ee494bc5c51 100644
> --- a/drivers/atm/horizon.c
> +++ b/drivers/atm/horizon.c
> @@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc)
>    
> 
>    // Part of the job is done by atm_pcr_goal which gives us a PCR
>    // specification which says: EITHER grab the maximum available PCR
> -  // (and perhaps a lower bound which we musn't pass), OR grab this
> +  // (and perhaps a lower bound which we mustn't pass), OR grab this

I meant to suggest you change the patch to use "must not" not
the commit message.

>    // amount, rounding down if you have to (and perhaps a lower bound
> -  // which we musn't pass) OR grab this amount, rounding up if you
> -  // have to (and perhaps an upper bound which we musn't pass). If any
> +  // which we mustn't pass) OR grab this amount, rounding up if you
> +  // have to (and perhaps an upper bound which we mustn't pass). If any
>    // bounds ARE passed we fail. Note that rounding is only rounding to
>    // match device limitations, we do not round down to satisfy
>    // bandwidth availability even if this would not violate any given



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [V2][PATCH] atm: horizon: Fix spelling mistakes in TX comment
  2021-08-07 16:58 ` Joe Perches
@ 2021-08-07 23:33   ` Jun Miao
  0 siblings, 0 replies; 5+ messages in thread
From: Jun Miao @ 2021-08-07 23:33 UTC (permalink / raw)
  To: Joe Perches, 3chas3; +Cc: linux-atm-general, netdev, linux-kernel


On 8/8/21 12:58 AM, Joe Perches wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
>
> On Sat, 2021-08-07 at 23:38 +0800, Jun Miao wrote:
>> It's "must not", not "musn't", meaning "shall not".
>> Let's fix that.
>>
>> Suggested-by: Joe Perches <joe@perches.com>
>> Signed-off-by: Jun Miao <jun.miao@windriver.com>
>> ---
>>   drivers/atm/horizon.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
>> index 4f2951cbe69c..9ee494bc5c51 100644
>> --- a/drivers/atm/horizon.c
>> +++ b/drivers/atm/horizon.c
>> @@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc)
>>
>>
>>     // Part of the job is done by atm_pcr_goal which gives us a PCR
>>     // specification which says: EITHER grab the maximum available PCR
>> -  // (and perhaps a lower bound which we musn't pass), OR grab this
>> +  // (and perhaps a lower bound which we mustn't pass), OR grab this
> I meant to suggest you change the patch to use "must not" not
> the commit message.

Please ignore this e-mail. Sorry, confuse the mailing list.

I am so careless to forget change there. After this 2 minutest, i send 
new  same V2(in fact should v3 but forgive for a freshman)

>>     // amount, rounding down if you have to (and perhaps a lower bound
>> -  // which we musn't pass) OR grab this amount, rounding up if you
>> -  // have to (and perhaps an upper bound which we musn't pass). If any
>> +  // which we mustn't pass) OR grab this amount, rounding up if you
>> +  // have to (and perhaps an upper bound which we mustn't pass). If any
>>     // bounds ARE passed we fail. Note that rounding is only rounding to
>>     // match device limitations, we do not round down to satisfy
>>     // bandwidth availability even if this would not violate any given
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [V2][PATCH] atm: horizon: Fix spelling mistakes in TX comment
  2021-08-07 15:41 Jun Miao
@ 2021-08-08 12:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-08 12:00 UTC (permalink / raw)
  To: Jun Miao; +Cc: 3chas3, linux-atm-general, netdev, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat,  7 Aug 2021 23:41:40 +0800 you wrote:
> It's "must not", not "musn't", meaning "shall not".
> Let's fix that.
> 
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Jun Miao <jun.miao@windriver.com>
> ---
>  drivers/atm/horizon.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Here is the summary with links:
  - [V2] atm: horizon: Fix spelling mistakes in TX comment
    https://git.kernel.org/netdev/net-next/c/64ec13ec92d5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [V2][PATCH] atm: horizon: Fix spelling mistakes in TX comment
@ 2021-08-07 15:41 Jun Miao
  2021-08-08 12:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 5+ messages in thread
From: Jun Miao @ 2021-08-07 15:41 UTC (permalink / raw)
  To: 3chas3; +Cc: linux-atm-general, netdev, linux-kernel, jun.miao

It's "must not", not "musn't", meaning "shall not".
Let's fix that.

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Jun Miao <jun.miao@windriver.com>
---
 drivers/atm/horizon.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
index 4f2951cbe69c..d0e67ec46216 100644
--- a/drivers/atm/horizon.c
+++ b/drivers/atm/horizon.c
@@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc)
   
   // Part of the job is done by atm_pcr_goal which gives us a PCR
   // specification which says: EITHER grab the maximum available PCR
-  // (and perhaps a lower bound which we musn't pass), OR grab this
+  // (and perhaps a lower bound which we must not pass), OR grab this
   // amount, rounding down if you have to (and perhaps a lower bound
-  // which we musn't pass) OR grab this amount, rounding up if you
-  // have to (and perhaps an upper bound which we musn't pass). If any
+  // which we must not pass) OR grab this amount, rounding up if you
+  // have to (and perhaps an upper bound which we must not pass). If any
   // bounds ARE passed we fail. Note that rounding is only rounding to
   // match device limitations, we do not round down to satisfy
   // bandwidth availability even if this would not violate any given
-- 
2.32.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-08-08 12:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-07 15:38 [V2][PATCH] atm: horizon: Fix spelling mistakes in TX comment Jun Miao
2021-08-07 16:58 ` Joe Perches
2021-08-07 23:33   ` Jun Miao
2021-08-07 15:41 Jun Miao
2021-08-08 12:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).