Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH net] netdevice.h: fix proto_down_reason kernel-doc warning
@ 2020-09-07 3:31 Randy Dunlap
2020-09-07 6:02 ` Roopa Prabhu
2020-09-07 19:49 ` Jakub Kicinski
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2020-09-07 3:31 UTC (permalink / raw)
To: netdev, David Miller, Roopa Prabhu, Jakub Kicinski
From: Randy Dunlap <rdunlap@infradead.org>
Fix kernel-doc warning in <linux/netdevice.h>:
../include/linux/netdevice.h:2158: warning: Function parameter or member 'proto_down_reason' not described in 'net_device'
Fixes: 829eb208e80d ("rtnetlink: add support for protodown reason")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Roopa Prabhu <roopa@cumulusnetworks.com>
---
include/linux/netdevice.h | 1 +
1 file changed, 1 insertion(+)
--- lnx-59-rc4.orig/include/linux/netdevice.h
+++ lnx-59-rc4/include/linux/netdevice.h
@@ -1784,6 +1784,7 @@ enum netdev_priv_flags {
* the watchdog (see dev_watchdog())
* @watchdog_timer: List of timers
*
+ * @proto_down_reason: reason a netdev interface is held down
* @pcpu_refcnt: Number of references to this device
* @todo_list: Delayed register/unregister
* @link_watch_list: XXX: need comments on this one
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] netdevice.h: fix proto_down_reason kernel-doc warning
2020-09-07 3:31 [PATCH net] netdevice.h: fix proto_down_reason kernel-doc warning Randy Dunlap
@ 2020-09-07 6:02 ` Roopa Prabhu
2020-09-07 19:49 ` Jakub Kicinski
1 sibling, 0 replies; 4+ messages in thread
From: Roopa Prabhu @ 2020-09-07 6:02 UTC (permalink / raw)
To: Randy Dunlap, netdev, David Miller, Roopa Prabhu, Jakub Kicinski
On 9/6/20 8:31 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kernel-doc warning in <linux/netdevice.h>:
>
> ../include/linux/netdevice.h:2158: warning: Function parameter or member 'proto_down_reason' not described in 'net_device'
>
> Fixes: 829eb208e80d ("rtnetlink: add support for protodown reason")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Roopa Prabhu <roopa@cumulusnetworks.com>
> ---
Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Thanks Randy
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] netdevice.h: fix proto_down_reason kernel-doc warning
2020-09-07 3:31 [PATCH net] netdevice.h: fix proto_down_reason kernel-doc warning Randy Dunlap
2020-09-07 6:02 ` Roopa Prabhu
@ 2020-09-07 19:49 ` Jakub Kicinski
2020-09-07 19:57 ` Randy Dunlap
1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2020-09-07 19:49 UTC (permalink / raw)
To: Randy Dunlap; +Cc: netdev, David Miller, Roopa Prabhu
On Sun, 6 Sep 2020 20:31:16 -0700 Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kernel-doc warning in <linux/netdevice.h>:
>
> ../include/linux/netdevice.h:2158: warning: Function parameter or member 'proto_down_reason' not described in 'net_device'
>
> Fixes: 829eb208e80d ("rtnetlink: add support for protodown reason")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Roopa Prabhu <roopa@cumulusnetworks.com>
Applied, but I had to fix a checkpatch warning about a space before a
tab..
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] netdevice.h: fix proto_down_reason kernel-doc warning
2020-09-07 19:49 ` Jakub Kicinski
@ 2020-09-07 19:57 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2020-09-07 19:57 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: netdev, David Miller, Roopa Prabhu
On 9/7/20 12:49 PM, Jakub Kicinski wrote:
> On Sun, 6 Sep 2020 20:31:16 -0700 Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix kernel-doc warning in <linux/netdevice.h>:
>>
>> ../include/linux/netdevice.h:2158: warning: Function parameter or member 'proto_down_reason' not described in 'net_device'
>>
>> Fixes: 829eb208e80d ("rtnetlink: add support for protodown reason")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> Applied, but I had to fix a checkpatch warning about a space before a
> tab..
Ohhh, thanks.
I blame that on (g)vim providing some automatic indentation that I didn't want.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-07 19:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-07 3:31 [PATCH net] netdevice.h: fix proto_down_reason kernel-doc warning Randy Dunlap
2020-09-07 6:02 ` Roopa Prabhu
2020-09-07 19:49 ` Jakub Kicinski
2020-09-07 19:57 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).