Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>, Sunil Goutham <sgoutham@marvell.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH v2 1/2] net: ethtool: Support setting ntuple rule count
Date: Mon, 26 Jul 2021 15:29:24 -0700	[thread overview]
Message-ID: <3bc237a32a1e823739e4e15df9758171c4051a66.camel@kernel.org> (raw)
In-Reply-To: <YPxMlaxjT0vSeqZg@lunn.ch>

On Sat, 2021-07-24 at 19:23 +0200, Andrew Lunn wrote:
> On Fri, Jul 23, 2021 at 11:46:45PM +0530, Sunil Goutham wrote:
> > Some NICs share resources like packet filters across
> > multiple interfaces they support. From HW point of view
> > it is possible to use all filters for a single interface.
> > Currently ethtool doesn't support modifying filter count so
> > that user can allocate more filters to a interface and less
> > to others. This patch adds ETHTOOL_SRXCLSRLCNT ioctl command
> > for modifying filter count.
> > 
> > example command:
> > ./ethtool -U eth0 rule-count 256
> 
> How can use see what the current usage is? How many in total you have
> available?  What the current split is between the interfaces?
> 

There is no point of adding this ethtool interface if the orchestration
tool already knows the "rule-count" in advance, it's just redundant to
have a user managed limiting device in ethtool.

> You say:
> 
>    * Jakub suggested if devlink-resource can be used for this.
> 
> devlink-resource provides you a standardised mechanism to answer the
> questions i just asked. So i would have to agree with Jakub.
> 

+1, devlink is your address when a single device is shared across
multiple interfaces.

>           Andrew



  reply	other threads:[~2021-07-26 22:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 18:16 [PATCH v2 0/2] Support ethtool ntuple rule count change Sunil Goutham
2021-07-23 18:16 ` [PATCH v2 1/2] net: ethtool: Support setting ntuple rule count Sunil Goutham
2021-07-24 17:23   ` Andrew Lunn
2021-07-26 22:29     ` Saeed Mahameed [this message]
2021-07-23 18:16 ` [PATCH v2 2/2] octeontx2-pf: " Sunil Goutham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3bc237a32a1e823739e4e15df9758171c4051a66.camel@kernel.org \
    --to=saeed@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sgoutham@marvell.com \
    --subject='Re: [PATCH v2 1/2] net: ethtool: Support setting ntuple rule count' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).