Netdev Archive on lore.kernel.org help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net> To: Johannes Berg <firstname.lastname@example.org>, Jakub Kicinski <email@example.com>, Linus Torvalds <firstname.lastname@example.org> Cc: Luca Coelho <email@example.com>, Kalle Valo <firstname.lastname@example.org>, David Miller <email@example.com>, Netdev <firstname.lastname@example.org>, Linux Kernel Mailing List <email@example.com>, Greg Kroah-Hartman <firstname.lastname@example.org>, email@example.com, Miri Korenblit <firstname.lastname@example.org> Subject: Re: [GIT PULL] Networking for v5.15 Date: Wed, 1 Sep 2021 16:48:44 -0500 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 9/1/21 14:49, Johannes Berg wrote: > On Wed, 2021-09-01 at 12:41 -0700, Jakub Kicinski wrote: >> >>> >>> They all seem to have that same issue, and it looks like the fix would >>> be to get the RTN lock in iwl_mvm_init_mcc(), but I didn't really look >>> into it very much. >>> >>> This is on my desktop, and I actually don't _use_ the wireless on this >>> machine. I assume it still works despite the warnings, but they should >>> get fixed. >>> >>> I *don't* see these warnings on my laptop where I actually use >>> wireless, but that one uses ath10k_pci, so it seems this is purely a >>> iwlwifi issue. >>> >>> I can't be the only one that sees this. Hmm? >> >> Mm. Looking thru the recent commits there is a suspicious rtnl_unlock() >> in commit eb09ae93dabf ("iwlwifi: mvm: load regdomain at INIT stage"). > > Huh! That's not the version of the commit I remember - it had an > rtnl_lock() in there too (just before the mutex_lock)?! Looks like that > should really be there, not sure how/where it got lost along the way. > > That unbalanced rtnl_unlock() makes no sense anyway. Wonder why it > doesn't cause more assertions/problems at that point, clearly it's > unbalanced. Pretty sure it's missing the rtnl_lock() earlier in the > function for some reason. > > Luca and I will look at it tomorrow, getting late here, sorry. > > johannes > I am seeing the same problem, and it does happen in lots of places. For example finger@2603-8090-2005-39b3-0000-0000-0000-1023:~/rtl8812au>dmesg | grep assertion\ failed [ 6.465589] RTNL: assertion failed at net/core/rtnetlink.c (1702) [ 6.465948] RTNL: assertion failed at net/core/devlink.c (11496) [ 6.466263] RTNL: assertion failed at net/core/rtnetlink.c (1412) [ 6.466500] RTNL: assertion failed at net/core/dev.c (1987) [ 6.466708] RTNL: assertion failed at net/core/fib_rules.c (1227) [ 6.466902] RTNL: assertion failed at net/ipv4/devinet.c (1526) [ 6.467097] RTNL: assertion failed at net/ipv4/igmp.c (1779) [ 6.467291] RTNL: assertion failed at net/ipv4/igmp.c (1432) I am in the process of bisecting the problem, just in case it happens some other place than your suspicion leads you. Larry
next prev parent reply other threads:[~2021-09-01 21:48 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-31 20:37 [GIT PULL] Networking for v5.15 Jakub Kicinski 2021-08-31 23:56 ` pr-tracker-bot 2021-09-01 19:00 ` Linus Torvalds 2021-09-01 19:41 ` Jakub Kicinski 2021-09-01 19:49 ` Johannes Berg 2021-09-01 21:48 ` Larry Finger [this message] 2021-09-02 9:33 ` Coelho, Luciano 2021-09-02 10:11 ` [PATCH] iwlwifi: mvm: add rtnl_lock() in iwl_mvm_start_get_nvm() Luca Coelho 2021-09-02 10:39 ` David Miller 2021-09-02 15:55 ` Linus Torvalds [not found] ` <CAP71bdV1eBm3f1qY0rfigK4VaW5icZ+hU0pw7g6fVM=hGbn7Xw@mail.gmail.com> 2021-09-02 17:16 ` [GIT PULL] Networking for v5.15 Linus Torvalds 2021-09-02 5:55 ` Larry Finger 2021-09-02 7:07 ` Johannes Berg 2021-09-02 0:02 ` John Stultz 2021-09-02 9:25 ` Dan Carpenter 2021-09-02 9:28 ` Srinivas Kandagatla 2021-09-02 10:08 ` [PATCH net] net: qrtr: revert check in qrtr_endpoint_post() Dan Carpenter 2021-09-02 10:40 ` patchwork-bot+netdevbpf 2021-09-04 3:08 ` [GIT PULL] Networking for v5.15 John Stultz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).