Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Hangbin Liu <liuhangbin@gmail.com>, netdev@vger.kernel.org
Cc: Jay Vosburgh <j.vosburgh@gmail.com>,
	Veaceslav Falico <vfalico@gmail.com>,
	Andy Gospodarek <andy@greyhouse.net>,
	Jarod Wilson <jarod@redhat.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH iproute2-next] ip/bond: add lacp active support
Date: Sun, 8 Aug 2021 12:17:06 -0600	[thread overview]
Message-ID: <4127d0f8-c88b-c535-21c2-6f54f6c30686@gmail.com> (raw)
In-Reply-To: <20210802030220.841726-2-liuhangbin@gmail.com>

On 8/1/21 9:02 PM, Hangbin Liu wrote:
> @@ -316,6 +324,13 @@ static int bond_parse_opt(struct link_util *lu, int argc, char **argv,
>  
>  			addattr32(n, 1024, IFLA_BOND_PACKETS_PER_SLAVE,
>  				  packets_per_slave);
> +		} else if (matches(*argv, "lacp_active") == 0) {
> +			NEXT_ARG();
> +			if (get_index(lacp_active_tbl, *argv) < 0)
> +				invarg("invalid lacp_active", *argv);
> +
> +			lacp_active = get_index(lacp_active_tbl, *argv);
> +			addattr8(n, 1024, IFLA_BOND_AD_LACP_ACTIVE, lacp_active);
>  		} else if (matches(*argv, "lacp_rate") == 0) {

The new argument needs to go after the older "lacp_rate" since it uses
matches. Also, let's stop using matches and move to a full strcmp for
new options.


  reply	other threads:[~2021-08-08 18:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02  3:02 [PATCHv2 net-next] bonding: add new option lacp_active Hangbin Liu
2021-08-02  3:02 ` [PATCH iproute2-next] ip/bond: add lacp active support Hangbin Liu
2021-08-08 18:17   ` David Ahern [this message]
2021-08-03 11:00 ` [PATCHv2 net-next] bonding: add new option lacp_active patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4127d0f8-c88b-c535-21c2-6f54f6c30686@gmail.com \
    --to=dsahern@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=j.vosburgh@gmail.com \
    --cc=jarod@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=vfalico@gmail.com \
    --subject='Re: [PATCH iproute2-next] ip/bond: add lacp active support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).