Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Hayes Wang <hayeswang@realtek.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "kuba@kernel.org" <kuba@kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	nic_swsd <nic_swsd@realtek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH net-next RESEND 2/2] r8152: separate the r8152.c into r8152_main.c and r8152_fw.c
Date: Mon, 26 Jul 2021 11:09:06 +0000	[thread overview]
Message-ID: <47801164b7b3406b895be1542e0ce4a2@realtek.com> (raw)
In-Reply-To: <YP50SIgqAEyKWSpA@kroah.com>

Greg KH <gregkh@linuxfoundation.org>
> Sent: Monday, July 26, 2021 4:37 PM
[...]
> You also do other things, like renaming defines, which is not just
> moving code around, right?

Yes. You are right.

[...]
> I do not know, is it really easier to find things in 3 different files
> instead of one?  That's up to you, but you did not say why this change
> is needed.

We support a new chip or feature with a test driver.
The test driver is similar with the upstream driver, except
the method of the firmware. After we confirm that the
test driver work fine, we compare the differences with
the upstream driver and submit patches. And the code
about firmware takes us more time to find out the
differences. Therefore, I wish to move the part of
the firmware out.

I don't sure if it is acceptable for such patches.
If it is unacceptable, I would abandon these patches.

Best Regards,
Hayes



  reply	other threads:[~2021-07-26 11:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13  9:18 [PATCH net-next 0/2] r8152: split the source code Hayes Wang
2021-07-13  9:18 ` [PATCH net-next 1/2] r8152: group the usb ethernet of realtek Hayes Wang
2021-07-13  9:18 ` [PATCH net-next 2/2] r8152: separate the r8152.c into r8152_main.c and r8152_fw.c Hayes Wang
2021-07-26  4:01 ` [PATCH net-next RESEND 0/2] r8152: split the source code Hayes Wang
2021-07-26  4:01   ` [PATCH net-next RESEND 1/2] r8152: group the usb ethernet of realtek Hayes Wang
2021-07-26  4:01   ` [PATCH net-next RESEND 2/2] r8152: separate the r8152.c into r8152_main.c and r8152_fw.c Hayes Wang
2021-07-26  7:36     ` Greg KH
2021-07-26  8:26       ` Hayes Wang
2021-07-26  8:37         ` Greg KH
2021-07-26 11:09           ` Hayes Wang [this message]
2021-07-26 11:14             ` Greg KH
2021-07-26 11:43               ` Hayes Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47801164b7b3406b895be1542e0ce4a2@realtek.com \
    --to=hayeswang@realtek.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --subject='RE: [PATCH net-next RESEND 2/2] r8152: separate the r8152.c into r8152_main.c and r8152_fw.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).