Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Shannon Nelson <snelson@pensando.io>
To: David Miller <davem@davemloft.net>, kuba@kernel.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/5] ionic: smaller coalesce default
Date: Mon, 31 Aug 2020 21:20:39 -0700	[thread overview]
Message-ID: <4bd7c866-4b99-bf3c-460e-8edf8fbf1e15@pensando.io> (raw)
In-Reply-To: <20200831.171613.1392501036623240615.davem@davemloft.net>

On 8/31/20 5:16 PM, David Miller wrote:
> From: Jakub Kicinski <kuba@kernel.org>
> Date: Mon, 31 Aug 2020 16:50:54 -0700
>
>> On Mon, 31 Aug 2020 16:35:55 -0700 Shannon Nelson wrote:
>>> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_dev.h b/drivers/net/ethernet/pensando/ionic/ionic_dev.h
>>> index 9e2ac2b8a082..2b2eb5f2a0e5 100644
>>> --- a/drivers/net/ethernet/pensando/ionic/ionic_dev.h
>>> +++ b/drivers/net/ethernet/pensando/ionic/ionic_dev.h
>>> @@ -16,7 +16,7 @@
>>>   #define IONIC_DEF_TXRX_DESC		4096
>>>   #define IONIC_LIFS_MAX			1024
>>>   #define IONIC_WATCHDOG_SECS		5
>>> -#define IONIC_ITR_COAL_USEC_DEFAULT	64
>>> +#define IONIC_ITR_COAL_USEC_DEFAULT	8
>> 8 us interrupt coalescing does not hurt general operations?! No way.
>>
>> It's your customers who'll get hurt here, so your call, but I seriously
>> doubt this. Unless the unit is not usec?
> Agreed, 8usec is really really low.  You won't get much coalescing during
> bulk transfers with a value like that, eliminating the gain from coalescing
> in the first place.

Thanks.  I'll drop this patch and come back to this issue when we get a 
chance to add adaptive coalescing.

sln



  reply	other threads:[~2020-09-01  4:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 23:35 [PATCH net-next 0/5] ionic: struct cleanups Shannon Nelson
2020-08-31 23:35 ` [PATCH net-next 1/5] ionic: clean up page handling code Shannon Nelson
2020-09-01  0:14   ` David Miller
2020-09-01  4:19     ` Shannon Nelson
2020-08-31 23:35 ` [PATCH net-next 2/5] ionic: smaller coalesce default Shannon Nelson
2020-08-31 23:50   ` Jakub Kicinski
2020-09-01  0:16     ` David Miller
2020-09-01  4:20       ` Shannon Nelson [this message]
2020-08-31 23:35 ` [PATCH net-next 3/5] ionic: struct reorder for faster access Shannon Nelson
2020-08-31 23:35 ` [PATCH net-next 4/5] ionic: clean up desc_info and cq_info structs Shannon Nelson
2020-08-31 23:35 ` [PATCH net-next 5/5] ionic: clean adminq service routine Shannon Nelson
2020-09-01  0:47 ` [PATCH net-next 0/5] ionic: struct cleanups Florian Fainelli
2020-09-01  4:21   ` Shannon Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bd7c866-4b99-bf3c-460e-8edf8fbf1e15@pensando.io \
    --to=snelson@pensando.io \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net-next 2/5] ionic: smaller coalesce default' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).