Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: Pavel Machek <pavel@ucw.cz>,
	eranbe@mellanox.com, lariel@mellanox.com, saeedm@mellanox.com,
	leon@kernel.org, davem@davemloft.net, kuba@kernel.org,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mlx5: remove unreachable return
Date: Tue, 22 Sep 2020 12:54:20 -0700	[thread overview]
Message-ID: <4eb581435bd7ac528c29815a7d26016bd1c429f4.camel@kernel.org> (raw)
In-Reply-To: <5d37fdcb0d50d79f93e8cdb31cb3f182548ffcc1.camel@kernel.org>

On Mon, 2020-09-21 at 22:54 -0700, Saeed Mahameed wrote:
> On Mon, 2020-09-21 at 13:41 +0200, Pavel Machek wrote:
> > The last return statement is unreachable code. I'm not sure if it
> > will
> > provoke any warnings, but it looks ugly.
> >     
> > Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
> > 
> > 
> 
> Applied to net-next-mlx5.
> 
> Thanks,
> Saeed.
> 

Actually checkpatch reports this issue:
WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal
patch author 'Pavel Machek <pavel@ucw.cz>'

Do you want me to override the Signed-off-by tag with the above email ?

Thanks,
Saeed.


  reply	other threads:[~2020-09-22 19:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21 11:41 Pavel Machek
2020-09-22  5:54 ` Saeed Mahameed
2020-09-22 19:54   ` Saeed Mahameed [this message]
2020-09-22 20:05     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4eb581435bd7ac528c29815a7d26016bd1c429f4.camel@kernel.org \
    --to=saeed@kernel.org \
    --cc=davem@davemloft.net \
    --cc=eranbe@mellanox.com \
    --cc=kuba@kernel.org \
    --cc=lariel@mellanox.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=saeedm@mellanox.com \
    --subject='Re: [PATCH] net/mlx5: remove unreachable return' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).