From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D21EFC432BE for ; Thu, 29 Jul 2021 17:28:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5C0F6052B for ; Thu, 29 Jul 2021 17:28:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232636AbhG2R2j (ORCPT ); Thu, 29 Jul 2021 13:28:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232429AbhG2R2d (ORCPT ); Thu, 29 Jul 2021 13:28:33 -0400 Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8293FC061765; Thu, 29 Jul 2021 10:28:29 -0700 (PDT) Received: by mail-oi1-x231.google.com with SMTP id q6so9393560oiw.7; Thu, 29 Jul 2021 10:28:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=T4634nEU7h1FMASxQlJXurHsCOwc8FrOI5tJXiiXeII=; b=ktpTazTWfguZ49pyVRHW8CWP7MID2LgaKgHZRwDP9C+D5e+fbBEK9XdGTXMDqWOPaC pR4EN+0ZyJS1h40sC88vRfULp01m8jWiB1rxvZ6e/cmk++MN+gh9jDTCsJwmA+o5TXPp y1klOH7188f78HV+Fnbwt4oEt5wb6LojxKbJKrO+OuwF71deVXsVtuqjEL7zGenz30oR r+mZmfOL4jD9AgBrhA6AQFNYIML2JJLr6v2pcN4tsYydl1WSGQNbR6m+62CuWiKl79i1 X4n4C3YfbfpxcGbqNAc343VKVlhRhDFafLNO21tj/tFQxnxEctBvTp+1jVpHYEExvo+f UGTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T4634nEU7h1FMASxQlJXurHsCOwc8FrOI5tJXiiXeII=; b=KAweBK4q/EvAo38i8LDkUaiqyI3zpfY1gKnYnCVoFYdAzGNhxniaCFSIDG8O/laO7T SBWLN5nTQoBPWO951IJcIRFegxkoSRNf8EgFqBYIfpwYvltJ3HjCWhON3zPNdgTCVffe u5dj0ndmOJkz1LWk+0XCIopIK9zAJOoUf8YuDHL05EBt1rTaxWJ7zjw7BXyLAo8GGytP 78GeA4h0ioJt8tSYSJwAsQo4fkENbpj7OgXIzdaJx3DDCxt85wf6MH3QikPLI9um3OPB cglkCneDRzFuRRqvsKp4MV5rtry+ZqsK3H2k2D7fEXtI+1J2yAd0JGkcvRJlkM9X2HJs iHhA== X-Gm-Message-State: AOAM531wf36rKqatR8AmCysspXfiarWTdmF7hBnovCvkYejxrowA5MuA h6XFTiA0joZc2TP75p6jo6k= X-Google-Smtp-Source: ABdhPJxoUx2dL4gO6cXj2XI9CKAW2Xkw2stlC8KQ+HBW6uwYZLrX61/EqE8spljKolA9iphj4rdhhg== X-Received: by 2002:aca:bc43:: with SMTP id m64mr11250240oif.174.1627579708922; Thu, 29 Jul 2021 10:28:28 -0700 (PDT) Received: from Davids-MacBook-Pro.local ([8.48.134.27]) by smtp.googlemail.com with ESMTPSA id h1sm648323otj.48.2021.07.29.10.28.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 10:28:28 -0700 (PDT) Subject: Re: [PATCH net-next] net: ipv6: add IFLA_RA_MTU to expose mtu value in the RA message To: Rocco Yue Cc: "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , Matthias Brugger , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, rocco.yue@gmail.com References: <20210729154251.1380-1-rocco.yue@mediatek.com> From: David Ahern Message-ID: <57652c0b-ded8-8386-c9a7-40deb1525db2@gmail.com> Date: Thu, 29 Jul 2021 11:28:26 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210729154251.1380-1-rocco.yue@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 7/29/21 9:42 AM, Rocco Yue wrote: > Because the purpose of this patch is for userspace to correctly read the > ra_mtu value of different network device, if the DEVCONF is completely dropped, > does that mean I can add the "ra_mtu" member in the "struct net_device" . good point. IFLA is the wrong attribute. It should be IFLA_INET6_RA_MTU, stored in inet6_dev and added to the link message in inet6_fill_ifla6_attrs.