Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pavel Skripkin <paskripkin@gmail.com>
To: netdev@vger.kernel.org, davem@davemloft.net,
	gregkh@linuxfoundation.org, Petko Manolov <petkan@nucleusys.com>
Subject: Re: [PATCH net 1/2] net: usb: pegasus: Check the return value of get_geristers() and friends;
Date: Tue, 3 Aug 2021 18:46:36 +0300	[thread overview]
Message-ID: <58f9122f-3ad3-9d6b-7ae3-5d5a83f19334@gmail.com> (raw)
In-Reply-To: <YQlkh54HdqQYZenw@carbon>

On 8/3/21 6:45 PM, Petko Manolov wrote:
> On 21-08-03 18:28:55, Pavel Skripkin wrote:
>> On 8/3/21 6:03 PM, Petko Manolov wrote:
>> > From: Petko Manolov <petkan@nucleusys.com>
>> > 
>> > Certain call sites of get_geristers() did not do proper error handling.  This
>> > could be a problem as get_geristers() typically return the data via pointer to a
>> > buffer.  If an error occured the code is carelessly manipulating the wrong data.
>> > 
>> > Signed-off-by: Petko Manolov <petkan@nucleusys.com>
>> 
>> Hi, Petko!
>> 
>> This patch looks good to me, but I found few small mistakes
> 
> Yeah, the patch was never compiled.  Sorry about it.  v2 is coming up.
> 

BTW: should this also go to stable with Fixes: 1da177e4c3f4 
("Linux-2.6.12-rc2")?


With regards,
Pavel Skripkin

  reply	other threads:[~2021-08-03 15:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03 15:03 [PATCH net 0/2] net: usb: pegasus: better error checking and DRIVER_VERSION removal Petko Manolov
2021-08-03 15:03 ` [PATCH net 1/2] net: usb: pegasus: Check the return value of get_geristers() and friends; Petko Manolov
2021-08-03 15:28   ` Pavel Skripkin
2021-08-03 15:45     ` Petko Manolov
2021-08-03 15:46       ` Pavel Skripkin [this message]
2021-08-03 16:15         ` Petko Manolov
2021-08-03 15:03 ` [PATCH net 2/2] net: usb: pegasus: Remove the changelog and DRIVER_VERSION Petko Manolov
2021-08-03 16:51   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58f9122f-3ad3-9d6b-7ae3-5d5a83f19334@gmail.com \
    --to=paskripkin@gmail.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=petkan@nucleusys.com \
    --subject='Re: [PATCH net 1/2] net: usb: pegasus: Check the return value of get_geristers() and friends;' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).