Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: John Fastabend <email@example.com>
To: Daniel Borkmann <firstname.lastname@example.org>,
Jesper Dangaard Brouer <email@example.com>,
Lorenz Bauer <firstname.lastname@example.org>
Cc: "Maciej Żenczykowski" <email@example.com>,
"Saeed Mahameed" <firstname.lastname@example.org>,
"Daniel Borkmann" <email@example.com>,
"Alexei Starovoitov" <firstname.lastname@example.org>,
"Lorenzo Bianconi" <email@example.com>,
"John Fastabend" <firstname.lastname@example.org>,
"Jakub Kicinski" <email@example.com>,
"Shaun Crampton" <firstname.lastname@example.org>,
"David Miller" <email@example.com>,
"Marek Majkowski" <firstname.lastname@example.org>
Subject: Re: BPF redirect API design issue for BPF-prog MTU feedback?
Date: Mon, 21 Sep 2020 11:04:09 -0700 [thread overview]
Message-ID: <5f68eb19cc0a2_17370208c9@john-XPS-13-9370.notmuch> (raw)
Daniel Borkmann wrote:
> On 9/21/20 2:49 PM, Jesper Dangaard Brouer wrote:
> > On Mon, 21 Sep 2020 11:37:18 +0100
> > Lorenz Bauer <email@example.com> wrote:
> >> On Sat, 19 Sep 2020 at 00:06, Maciej Żenczykowski <firstname.lastname@example.org> wrote:
> >>>> This is a good point. As bpf_skb_adjust_room() can just be run after
> >>>> bpf_redirect() call, then a MTU check in bpf_redirect() actually
> >>>> doesn't make much sense. As clever/bad BPF program can then avoid the
> >>>> MTU check anyhow. This basically means that we have to do the MTU
> >>>> check (again) on kernel side anyhow to catch such clever/bad BPF
> >>>> programs. (And I don't like wasting cycles on doing the same check two
> >>>> times).
> >>> If you get rid of the check in bpf_redirect() you might as well get
> >>> rid of *all* the checks for excessive mtu in all the helpers that
> >>> adjust packet size one way or another way. They *all* then become
> >>> useless overhead.
> >>> I don't like that. There may be something the bpf program could do to
> >>> react to the error condition (for example in my case, not modify
> >>> things and just let the core stack deal with things - which will
> >>> probably just generate packet too big icmp error).
> >>> btw. right now our forwarding programs first adjust the packet size
> >>> then call bpf_redirect() and almost immediately return what it
> >>> returned.
> >>> but this could I think easily be changed to reverse the ordering, so
> >>> we wouldn't increase packet size before the core stack was informed we
> >>> would be forwarding via a different interface.
> >> We do the same, except that we also use XDP_TX when appropriate. This
> >> complicates the matter, because there is no helper call we could
> >> return an error from.
> > Do notice that my MTU work is focused on TC-BPF. For XDP-redirect the
> > MTU check is done in xdp_ok_fwd_dev() via __xdp_enqueue(), which also
> > happens too late to give BPF-prog knowledge/feedback. For XDP_TX I
> > audited the drivers when I implemented xdp_buff.frame_sz, and they
> > handled (or I added) handling against max HW MTU. E.g. mlx5 .
> >  https://elixir.bootlin.com/linux/v5.9-rc6/source/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c#L267
> >> My preference would be to have three helpers: get MTU for a device,
> >> redirect ctx to a device (with MTU check), resize ctx (without MTU
> >> check) but that doesn't work with XDP_TX. Your idea of doing checks
> >> in redirect and adjust_room is pragmatic and seems easier to
> >> implement.
> > I do like this plan/proposal (with 3 helpers), but it is not possible
> > with current API. The main problem is the current bpf_redirect API
> > doesn't provide the ctx, so we cannot do the check in the BPF-helper.
> > Are you saying we should create a new bpf_redirect API (that incl packet ctx)?
> Sorry for jumping in late here... one thing that is not clear to me is that if
> we are fully sure that skb is dropped by stack anyway due to invalid MTU (redirect
> to ingress does this via dev_forward_skb(), it's not fully clear to me whether it's
> also the case for the dev_queue_xmiy()), then why not dropping all the MTU checks
> aside from SKB_MAX_ALLOC sanity check for BPF helpers and have something like a
> device object (similar to e.g. TCP sockets) exposed to BPF prog where we can retrieve
> the object and read dev->mtu from the prog, so the BPF program could then do the
> "exception" handling internally w/o extra prog needed (we also already expose whether
> skb is GSO or not).
My $.02 is MTU should only apply to transmitted packets so redirect to
ingress should be OK. Then on transmit shouldn't the user know the MTU
on their devices?
I'm for dropping all the MTU checks and if a driver tosses a packet then
the user should be more careful. Having a bpf helper to check MTU of a
dev seems useful although the workaround would be a map the user could
put the max MTU in. Of course that would be a bit fragile if the BPF program
and person managing MTU are not in-sync.
next prev parent reply other threads:[~2020-09-21 18:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 12:38 Jesper Dangaard Brouer
2020-09-17 12:54 ` Maciej Żenczykowski
2020-09-17 19:11 ` Saeed Mahameed
2020-09-18 10:00 ` Jesper Dangaard Brouer
2020-09-18 10:34 ` Toke Høiland-Jørgensen
2020-09-18 23:06 ` Maciej Żenczykowski
2020-09-21 10:37 ` Lorenz Bauer
2020-09-21 12:49 ` Jesper Dangaard Brouer
2020-09-21 15:08 ` Daniel Borkmann
2020-09-21 16:21 ` Marek Zavodsky
2020-09-21 21:17 ` Willem de Bruijn
2020-09-22 9:15 ` Jesper Dangaard Brouer
2020-09-21 16:26 ` Jesper Dangaard Brouer
2020-09-22 6:56 ` Eyal Birger
2020-09-21 18:04 ` John Fastabend [this message]
2020-10-06 11:45 ` Jesper Dangaard Brouer
2020-09-21 10:42 ` Lorenz Bauer
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: BPF redirect API design issue for BPF-prog MTU feedback?' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).