Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH net] net: macb: fix for pause frame receive enable bit
@ 2020-09-05 8:21 Parshuram Thombare
2020-09-06 19:04 ` Jakub Kicinski
2020-09-07 7:14 ` Nicolas Ferre
0 siblings, 2 replies; 3+ messages in thread
From: Parshuram Thombare @ 2020-09-05 8:21 UTC (permalink / raw)
To: nicolas.ferre, alexandre.belloni
Cc: claudiu.beznea, antoine.tenart, davem, netdev, f.fainelli,
linux-kernel, mparab, Parshuram Thombare
PAE bit of NCFGR register, when set, pauses transmission
if a non-zero 802.3 classic pause frame is received.
Fixes: 7897b071ac3b ("net: macb: convert to phylink")
Signed-off-by: Parshuram Thombare <pthombar@cadence.com>
---
drivers/net/ethernet/cadence/macb_main.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 6761f40..9179f7b 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -647,8 +647,7 @@ static void macb_mac_link_up(struct phylink_config *config,
ctrl |= GEM_BIT(GBE);
}
- /* We do not support MLO_PAUSE_RX yet */
- if (tx_pause)
+ if (rx_pause)
ctrl |= MACB_BIT(PAE);
macb_set_tx_clk(bp->tx_clk, speed, ndev);
--
1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net: macb: fix for pause frame receive enable bit
2020-09-05 8:21 [PATCH net] net: macb: fix for pause frame receive enable bit Parshuram Thombare
@ 2020-09-06 19:04 ` Jakub Kicinski
2020-09-07 7:14 ` Nicolas Ferre
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-09-06 19:04 UTC (permalink / raw)
To: Parshuram Thombare
Cc: nicolas.ferre, alexandre.belloni, claudiu.beznea, antoine.tenart,
davem, netdev, f.fainelli, linux-kernel, mparab
On Sat, 5 Sep 2020 10:21:33 +0200 Parshuram Thombare wrote:
> PAE bit of NCFGR register, when set, pauses transmission
> if a non-zero 802.3 classic pause frame is received.
>
> Fixes: 7897b071ac3b ("net: macb: convert to phylink")
> Signed-off-by: Parshuram Thombare <pthombar@cadence.com>
Applied, thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net: macb: fix for pause frame receive enable bit
2020-09-05 8:21 [PATCH net] net: macb: fix for pause frame receive enable bit Parshuram Thombare
2020-09-06 19:04 ` Jakub Kicinski
@ 2020-09-07 7:14 ` Nicolas Ferre
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2020-09-07 7:14 UTC (permalink / raw)
To: Parshuram Thombare, alexandre.belloni
Cc: claudiu.beznea, antoine.tenart, davem, netdev, f.fainelli,
linux-kernel, mparab
On 05/09/2020 at 10:21, Parshuram Thombare wrote:
> PAE bit of NCFGR register, when set, pauses transmission
> if a non-zero 802.3 classic pause frame is received.
>
> Fixes: 7897b071ac3b ("net: macb: convert to phylink")
> Signed-off-by: Parshuram Thombare <pthombar@cadence.com>
For the record:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks Parshuram for having found this issue.
Best regards,
Nicolas
> ---
> drivers/net/ethernet/cadence/macb_main.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 6761f40..9179f7b 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -647,8 +647,7 @@ static void macb_mac_link_up(struct phylink_config *config,
> ctrl |= GEM_BIT(GBE);
> }
>
> - /* We do not support MLO_PAUSE_RX yet */
> - if (tx_pause)
> + if (rx_pause)
> ctrl |= MACB_BIT(PAE);
>
> macb_set_tx_clk(bp->tx_clk, speed, ndev);
> --
> 1.7.1
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-07 7:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-05 8:21 [PATCH net] net: macb: fix for pause frame receive enable bit Parshuram Thombare
2020-09-06 19:04 ` Jakub Kicinski
2020-09-07 7:14 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).