Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: Martin KaFai Lau <kafai@fb.com>,
	John Fastabend <john.fastabend@gmail.com>
Cc: jakub@cloudflare.com, daniel@iogearbox.net,
	xiyou.wangcong@gmail.com, alexei.starovoitov@gmail.com,
	bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH bpf v2 3/3] bpf, sockmap: fix memleak on ingress msg enqueue
Date: Tue, 27 Jul 2021 09:01:50 -0700	[thread overview]
Message-ID: <61002dee75048_199a412083e@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <20210727043205.24ldyis5g5yvg4mm@kafai-mbp.dhcp.thefacebook.com>

Martin KaFai Lau wrote:
> On Mon, Jul 26, 2021 at 09:53:04AM -0700, John Fastabend wrote:
> > --- a/include/linux/skmsg.h
> > +++ b/include/linux/skmsg.h
> > @@ -285,11 +285,45 @@ static inline struct sk_psock *sk_psock(const struct sock *sk)
> >  	return rcu_dereference_sk_user_data(sk);
> >  }
> >  
> > +static inline void sk_psock_set_state(struct sk_psock *psock,
> > +				      enum sk_psock_state_bits bit)
> > +{
> > +	set_bit(bit, &psock->state);
> > +}
> > +
> > +static inline void sk_psock_clear_state(struct sk_psock *psock,
> > +					enum sk_psock_state_bits bit)
> > +{
> > +	clear_bit(bit, &psock->state);
> > +}
> > +
> > +static inline bool sk_psock_test_state(const struct sk_psock *psock,
> > +				       enum sk_psock_state_bits bit)
> > +{
> > +	return test_bit(bit, &psock->state);
> > +}
> > +
> > +static void sock_drop(struct sock *sk, struct sk_buff *skb)
> inline


Thanks will fix, bit surprised I didn't get a build warning for the typo.

      reply	other threads:[~2021-07-27 16:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26 16:53 [PATCH bpf v2 0/3] sockmap fixes picked up by stress tests John Fastabend
2021-07-26 16:53 ` [PATCH bpf v2 1/3] bpf, sockmap: zap ingress queues after stopping strparser John Fastabend
2021-07-26 16:53 ` [PATCH bpf v2 2/3] bpf, sockmap: on cleanup we additionally need to remove cached skb John Fastabend
2021-07-26 16:53 ` [PATCH bpf v2 3/3] bpf, sockmap: fix memleak on ingress msg enqueue John Fastabend
2021-07-27  4:32   ` Martin KaFai Lau
2021-07-27 16:01     ` John Fastabend [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61002dee75048_199a412083e@john-XPS-13-9370.notmuch \
    --to=john.fastabend@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=jakub@cloudflare.com \
    --cc=kafai@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    --subject='Re: [PATCH bpf v2 3/3] bpf, sockmap: fix memleak on ingress msg enqueue' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).