Netdev Archive on
help / color / mirror / Atom feed
From: Paolo Abeni <>
To: Coco Li <>,
	Willem de Bruijn <>
Subject: Re: [PATCH net-next 1/2] selftests/net: GRO coalesce test
Date: Thu, 05 Aug 2021 13:16:37 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


On Thu, 2021-08-05 at 07:36 +0000, Coco Li wrote:
> Implement a GRO testsuite that expects Linux kernel GRO behavior.
> All tests pass with the kernel software GRO stack. Run against a device
> with hardware GRO to verify that it matches the software stack.
> gro.c generates packets and sends them out through a packet socket. The
> receiver in gro.c (run separately) receives the packets on a packet
> socket, filters them by destination ports using BPF and checks the
> packet geometry to see whether GRO was applied.
> provides a wrapper to run the gro.c in NIC loopback mode.
> It is not included in continuous testing because it modifies network
> configuration around a physical NIC: sets the NIC in loopback
> mode, creates macvlan devices on the physical device in separate
> namespaces, and sends traffic generated by gro.c between the two
> namespaces to observe coalescing behavior.

I like this idea a lot!

Have you considered additionally run the same test of top of a veth
pair, and have such tests always enabled, so we could have some
coverage regardless of specific H/W available?

To do the above you should disable TSO on the veth sender peer and
enable GRO on the other end.

> +  setup_ns
> +  # Each test is run 3 times to deflake, because given the receive timing,
> +  # not all packets that should coalesce will be considered in the same flow
> +  # on every try.

I thought that tuning 'gro_flush_timeout' appropriatelly, you should be
able to control exactly which packets will be aggregated ???



  reply	other threads:[~2021-08-05 11:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05  7:36 [PATCH net-next 0/2] GRO and Toeplitz hash selftests Coco Li
2021-08-05  7:36 ` [PATCH net-next 1/2] selftests/net: GRO coalesce test Coco Li
2021-08-05 11:16   ` Paolo Abeni [this message]
2021-08-05 20:21     ` Coco Li
     [not found]     ` <>
2021-08-06  7:49       ` Paolo Abeni
2021-08-06 17:44         ` Coco Li
2021-08-05  7:36 ` [PATCH net-next 2/2] selftests/net: toeplitz test Coco Li
2021-08-05 12:30 ` [PATCH net-next 0/2] GRO and Toeplitz hash selftests patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH net-next 1/2] selftests/net: GRO coalesce test' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).