Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: dariobin@libero.it
To: Jonathan Lemon <jonathan.lemon@gmail.com>,
	davem@davemloft.net, richardcochran@gmail.com
Cc: kernel-team@fb.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] ptp: Relocate lookup cookie to correct block.
Date: Sat, 10 Jul 2021 15:13:17 +0200 (CEST)	[thread overview]
Message-ID: <691638583.174057.1625922797445@mail1.libero.it> (raw)
In-Reply-To: <20210708180408.3930614-1-jonathan.lemon@gmail.com>

Hi Jonathan,
IMHO it is unfair that I am not the commit author of this patch.

Thanks and regards,
Dario

> Il 08/07/2021 20:04 Jonathan Lemon <jonathan.lemon@gmail.com> ha scritto:
> 
>  
> An earlier commit set the pps_lookup cookie, but the line
> was somehow added to the wrong code block.  Correct this.
> 
> Fixes: 8602e40fc813 ("ptp: Set lookup cookie when creating a PTP PPS source.")
> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
> Signed-off-by: Dario Binacchi <dariobin@libero.it>
> Acked-by: Richard Cochran <richardcochran@gmail.com>
> ---
>  drivers/ptp/ptp_clock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
> index ce6d9fc85607..4dfc52e06704 100644
> --- a/drivers/ptp/ptp_clock.c
> +++ b/drivers/ptp/ptp_clock.c
> @@ -232,7 +232,6 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
>  			pr_err("failed to create ptp aux_worker %d\n", err);
>  			goto kworker_err;
>  		}
> -		ptp->pps_source->lookup_cookie = ptp;
>  	}
>  
>  	/* PTP virtual clock is being registered under physical clock */
> @@ -268,6 +267,7 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
>  			pr_err("failed to register pps source\n");
>  			goto no_pps;
>  		}
> +		ptp->pps_source->lookup_cookie = ptp;
>  	}
>  
>  	/* Initialize a new device of our class in our clock structure. */
> -- 
> 2.30.2

  parent reply	other threads:[~2021-07-10 13:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 18:04 Jonathan Lemon
2021-07-08 19:40 ` patchwork-bot+netdevbpf
2021-07-10 13:13 ` dariobin [this message]
2021-07-10 16:56   ` Jonathan Lemon
2021-07-10 17:09     ` dariobin
2021-07-12  3:16     ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=691638583.174057.1625922797445@mail1.libero.it \
    --to=dariobin@libero.it \
    --cc=davem@davemloft.net \
    --cc=jonathan.lemon@gmail.com \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --subject='Re: [PATCH net] ptp: Relocate lookup cookie to correct block.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).