Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Miller <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 0/4] ethtool: runtime-resume netdev parent before ethtool ops
Date: Mon, 2 Aug 2021 21:00:44 +0200	[thread overview]
Message-ID: <69438f4b-34f0-3027-d1af-d8cf6e7943c6@gmail.com> (raw)
In-Reply-To: <20210802095446.22364041@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On 02.08.2021 18:54, Jakub Kicinski wrote:
> On Mon, 2 Aug 2021 18:42:28 +0200 Heiner Kallweit wrote:
>> On 02.08.2021 16:15, Jakub Kicinski wrote:
>>> On Sun, 1 Aug 2021 18:25:52 +0200 Heiner Kallweit wrote:  
>>>> Patchwork is showing the following warning for all patches in the series.
>>>>
>>>> netdev/cc_maintainers	warning	7 maintainers not CCed: ecree@solarflare.com andrew@lunn.ch magnus.karlsson@intel.com danieller@nvidia.com arnd@arndb.de irusskikh@marvell.com alexanderduyck@fb.com
>>>>
>>>> This seems to be a false positive, e.g. address ecree@solarflare.com
>>>> doesn't exist at all in MAINTAINERS file.  
>>>
>>> It gets the list from the get_maintainers script. It's one of the less
>>> reliable tests, but I feel like efforts should be made primarily
>>> towards improving get_maintainers rather than improving the test itself.
>>>   
>> When running get_maintainers.pl for any of the patches in the series
>> I don't get these addresses. I run get_maintainers w/o options, maybe
>> you set some special option? That's what I get when running get_maintainers:
>>
>> "David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING [GENERAL])
>> Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING [GENERAL])
>> Stephen Rothwell <sfr@canb.auug.org.au> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:3144/3159=100%)
>> Heiner Kallweit <hkallweit1@gmail.com> (commit_signer:1/2=50%,authored:1/2=50%,removed_lines:3/3=100%)
>> netdev@vger.kernel.org (open list:NETWORKING [GENERAL])
>> linux-kernel@vger.kernel.org (open list)
> 
> Mm. Maybe your system doesn't have some perl module? Not sure what it
> may be. With tip of net-next/master:
> 
> $ ./scripts/get_maintainer.pl /tmp/te/0002-ethtool-move-implementation-of-ethnl_ops_begin-compl.patch
> "David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING [GENERAL],commit_signer:12/16=75%,commit_signer:15/18=83%)
> Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING [GENERAL],commit_signer:11/16=69%,authored:9/16=56%,added_lines:127/198=64%,removed_lines:41/57=72%,commit_signer:14/18=78%,authored:11/18=61%,added_lines:74/84=88%,removed_lines:35/52=67%)
> Heiner Kallweit <hkallweit1@gmail.com> (commit_signer:3/16=19%,authored:3/16=19%,added_lines:46/198=23%,removed_lines:13/57=23%,authored:1/18=6%,removed_lines:13/52=25%)
> Fernando Fernandez Mancera <ffmancera@riseup.net> (commit_signer:1/16=6%,authored:1/16=6%)
> Vladyslav Tarasiuk <vladyslavt@nvidia.com> (commit_signer:1/16=6%,added_lines:11/198=6%,commit_signer:1/18=6%)
> Yangbo Lu <yangbo.lu@nxp.com> (authored:1/16=6%,added_lines:10/198=5%,authored:1/18=6%)
> Johannes Berg <johannes.berg@intel.com> (authored:1/16=6%)
> Zheng Yongjun <zhengyongjun3@huawei.com> (commit_signer:1/18=6%)
> Andrew Lunn <andrew@lunn.ch> (commit_signer:1/18=6%)
> Danielle Ratson <danieller@nvidia.com> (authored:1/18=6%)
> Ido Schimmel <idosch@nvidia.com> (authored:1/18=6%)
> netdev@vger.kernel.org (open list:NETWORKING [GENERAL])
> linux-kernel@vger.kernel.org (open list)
> 

Ah, maybe it's because I typically don't work with the full git repo
but just do a "git clone --depth 1". 

  reply	other threads:[~2021-08-02 19:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-01 10:35 Heiner Kallweit
2021-08-01 10:36 ` [PATCH net-next 1/4] ethtool: runtime-resume netdev parent before ethtool ioctl ops Heiner Kallweit
2021-08-03 20:41   ` Grygorii Strashko
2021-08-03 21:32     ` Heiner Kallweit
2021-08-04  8:43       ` Grygorii Strashko
2021-08-04 19:33         ` Heiner Kallweit
2021-08-05  8:20           ` Grygorii Strashko
2021-08-05 11:11             ` Joakim Zhang
2021-08-05 11:58               ` Grygorii Strashko
2021-08-05 19:24             ` Heiner Kallweit
2021-08-05 20:00               ` Grygorii Strashko
2021-08-01 10:37 ` [PATCH net-next 2/4] ethtool: move implementation of ethnl_ops_begin/complete to netlink.c Heiner Kallweit
2021-08-01 10:40 ` [PATCH net-next 3/4] ethtool: move netif_device_present check from ethnl_parse_header_dev_get to ethnl_ops_begin Heiner Kallweit
2021-08-01 10:41 ` [PATCH net-next 4/4] ethtool: runtime-resume netdev parent in ethnl_ops_begin Heiner Kallweit
2021-08-05 11:51   ` Julian Wiedmann
2021-08-05 18:48     ` Heiner Kallweit
2021-08-01 16:25 ` [PATCH net-next 0/4] ethtool: runtime-resume netdev parent before ethtool ops Heiner Kallweit
2021-08-02 14:15   ` Jakub Kicinski
2021-08-02 16:42     ` Heiner Kallweit
2021-08-02 16:54       ` Jakub Kicinski
2021-08-02 19:00         ` Heiner Kallweit [this message]
2021-08-03 12:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69438f4b-34f0-3027-d1af-d8cf6e7943c6@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net-next 0/4] ethtool: runtime-resume netdev parent before ethtool ops' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).