Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Michael Chan <michael.chan@broadcom.com>,
	Vijay Balakrishna <vijayb@linux.microsoft.com>
Cc: Netdev <netdev@vger.kernel.org>
Subject: Re: [bnxt] Error: Unable to read VPD
Date: Tue, 11 Jan 2022 20:41:18 +0100	[thread overview]
Message-ID: <6d6ff22c-df69-36c2-4d42-03ed7f539761@gmail.com> (raw)
In-Reply-To: <CACKFLim=ENcZMk+8UUwg87PPdu6zDC1Ld5b54Pp+_WSow9g_Og@mail.gmail.com>

On 10.01.2022 22:15, Michael Chan wrote:
> On Mon, Jan 10, 2022 at 1:02 PM Vijay Balakrishna
> <vijayb@linux.microsoft.com> wrote:
>>
>>
>> Since moving to 5.10 from 5.4 we are seeing
>>
>>> Jan 01 00:00:01 localhost kernel: bnxt_en 0008:01:00.0 (unnamed net_device) (uninitialized): Unable to read VPD
>>>
>>> Jan 01 00:00:01 localhost kernel: bnxt_en 0008:01:00.1 (unnamed net_device) (uninitialized): Unable to read VPD
>>
>> these appear to be harmless and introduced by
>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a0d0fd70fed5cc4f1e2dd98b801be63b07b4d6ac
>> Does "Unable to read VPD" need to be an error or can it be a warning
>> (netdev_warn)?
>>
> 
> We can change these to warnings.  Thanks.

Since 5.15 it is a pci_warn() already. Supposedly "Unable to read VPD" here simply means
that the device has no (valid) VPD. Does "lspci -vv" list any VPD info?
If VPD is an optional feature, then maybe the warning should be changed to info level
and the text should be less alarming.

  reply	other threads:[~2022-01-11 19:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10 21:02 Vijay Balakrishna
2022-01-10 21:15 ` Michael Chan
2022-01-11 19:41   ` Heiner Kallweit [this message]
2022-01-11 21:12     ` Vijay Balakrishna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d6ff22c-df69-36c2-4d42-03ed7f539761@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=vijayb@linux.microsoft.com \
    --subject='Re: [bnxt] Error: Unable to read VPD' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).