Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: Kuniyuki Iwashima <kuniyu@amazon.co.jp>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>
Cc: Benjamin Herrenschmidt <benh@amazon.com>,
	Kuniyuki Iwashima <kuni1840@gmail.com>, <bpf@vger.kernel.org>,
	<netdev@vger.kernel.org>
Subject: Re: [PATCH v4 bpf-next 3/3] selftest/bpf: Implement sample UNIX domain socket iterator program.
Date: Tue, 10 Aug 2021 16:46:49 -0700	[thread overview]
Message-ID: <6ef818ee-ee75-b2f0-5532-7cc3fa4eb68e@fb.com> (raw)
In-Reply-To: <20210810092807.13190-4-kuniyu@amazon.co.jp>



On 8/10/21 2:28 AM, Kuniyuki Iwashima wrote:
> The iterator can output the same result compared to /proc/net/unix.
> 
>    # cat /sys/fs/bpf/unix
>    Num       RefCount Protocol Flags    Type St Inode Path
>    ffff9ab7122db000: 00000002 00000000 00010000 0001 01 10623 private/defer

There seems a misalignment between header line and data line.
I know /proc/net/unix having this issue as well. But can we adjust 
spacing in bpf program to make header/data properly aligned?

>    ffff9fca0023d000: 00000002 00000000 00000000 0001 01 11058 @Hello@World@
> 
>    # cat /proc/net/unix
>    Num       RefCount Protocol Flags    Type St Inode Path
>    ffff9ab7122db000: 00000002 00000000 00010000 0001 01 10623 private/defer
>    ffff9fca0023d000: 00000002 00000000 00000000 0001 01 11058 @Hello@World@
> 
> Note that this prog requires the patch ([0]) for LLVM code gen.  Thanks to
> Yonghong Song for analysing and fixing.
> 
> [0] https://reviews.llvm.org/D107483
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>

LGTM. Thanks!

Acked-by: Yonghong Song <yhs@fb.com>

  reply	other threads:[~2021-08-10 23:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10  9:28 [PATCH v4 bpf-next 0/3] BPF iterator for UNIX domain socket Kuniyuki Iwashima
2021-08-10  9:28 ` [PATCH v4 bpf-next 1/3] bpf: af_unix: Implement " Kuniyuki Iwashima
2021-08-10 23:25   ` Yonghong Song
2021-08-10  9:28 ` [PATCH v4 bpf-next 2/3] bpf: Support "%c" in bpf_bprintf_prepare() Kuniyuki Iwashima
2021-08-10 23:32   ` Yonghong Song
2021-08-11 21:15   ` Andrii Nakryiko
2021-08-12  2:15     ` Kuniyuki Iwashima
2021-08-12  4:24       ` Andrii Nakryiko
2021-08-12  5:03         ` Kuniyuki Iwashima
2021-08-10  9:28 ` [PATCH v4 bpf-next 3/3] selftest/bpf: Implement sample UNIX domain socket iterator program Kuniyuki Iwashima
2021-08-10 23:46   ` Yonghong Song [this message]
2021-08-11  1:35     ` Kuniyuki Iwashima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ef818ee-ee75-b2f0-5532-7cc3fa4eb68e@fb.com \
    --to=yhs@fb.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=benh@amazon.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuni1840@gmail.com \
    --cc=kuniyu@amazon.co.jp \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --subject='Re: [PATCH v4 bpf-next 3/3] selftest/bpf: Implement sample UNIX domain socket iterator program.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).