Netdev Archive on
help / color / mirror / Atom feed
From: David Christensen <>
To: Michael Chan <>,
Subject: Re: [PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.
Date: Tue, 8 Sep 2020 09:55:46 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 9/3/20 11:28 AM, Michael Chan wrote:
> If tg3_reset_task() fails, the device state is left in an inconsistent
> state with IFF_RUNNING still set but NAPI state not enabled.  A
> subsequent operation, such as ifdown or AER error can cause it to
> soft lock up when it tries to disable NAPI state.
> Fix it by bringing down the device to !IFF_RUNNING state when
> tg3_reset_task() fails.  tg3_reset_task() running from workqueue
> will now call tg3_close() when the reset fails.  We need to
> modify tg3_reset_task_cancel() slightly to avoid tg3_close()
> calling cancel_work_sync() to cancel tg3_reset_task().  Otherwise
> cancel_work_sync() will wait forever for tg3_reset_task() to
> finish.
> Reported-by: David Christensen <>
> Reported-by: Baptiste Covolato <>
> Fixes: db2199737990 ("tg3: Schedule at most one tg3_reset_task run")
> Signed-off-by: Michael Chan <>

Thanks for the patch, I'll have some test time scheduled and let you know.


  parent reply	other threads:[~2020-09-08 16:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 18:28 Michael Chan
2020-09-03 19:24 ` David Miller
2020-09-04 23:20 ` Baptiste Covolato
2020-09-05  9:02   ` Michael Chan
2020-09-10 23:00     ` Baptiste Covolato
2020-09-08 16:55 ` David Christensen [this message]
2020-10-07 16:54 Tomas Charvat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).