Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Zhen Chen <chenzhen126@huawei.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: syzbot <syzbot+2e3efb5eb71cb5075ba7@syzkaller.appspotmail.com>,
	<davem@davemloft.net>, <jhs@mojatatu.com>, <jiri@resnulli.us>,
	<kuba@kernel.org>, <linux-kernel@vger.kernel.org>,
	<netdev@vger.kernel.org>, <syzkaller-bugs@googlegroups.com>,
	<xiyou.wangcong@gmail.com>, <rose.chen@huawei.com>
Subject: Re: [syzbot] WARNING: ODEBUG bug in route4_destroy
Date: Wed, 15 Jun 2022 19:57:42 +0800	[thread overview]
Message-ID: <786e43b7-fe00-ffde-ed9a-f47a695c4123@huawei.com> (raw)
In-Reply-To: <20220614144602.GJ2146@kadam>



On 22/6/14 22:46, Dan Carpenter wrote:
> On Tue, Jun 14, 2022 at 10:35:44PM +0800, 'Zhen Chen' via syzkaller-bugs wrote:
>>
>> This looks like  route4_destroy is deleting the 'fold' which has been
>> freed by tcf_queue_work in route4_change. It means 'fold' is still in
>> the table.
>> I have tested this patch on syzbot and it works well, but I am not
>> sure whether it will introduce other issues...
>>
>> diff --git a/net/sched/cls_route.c b/net/sched/cls_route.c
>> index a35ab8c27866..758c21f9d628 100644
>> --- a/net/sched/cls_route.c
>> +++ b/net/sched/cls_route.c
>> @@ -526,7 +526,7 @@ static int route4_change(struct net *net, struct sk_buff *in_skb,
>>  	rcu_assign_pointer(f->next, f1);
>>  	rcu_assign_pointer(*fp, f);
>>  
>> -	if (fold && fold->handle && f->handle != fold->handle) {
>> +	if (fold && f->handle != fold->handle) {
>                                  ^^^^^^^^^^^^
> There is still a dereference here so your patch doesn't make sense. :/
> 
> regards,
> dan carpenter

Thanks for your reply but I think the dereference may not be the point.
If fold->handle equals 0, it will not be removed from the hash table, but afterwards the old filter will be freed because it only checks the pointer 'fold' is null or not.

if (fold) {
	tcf_unbind_filter(tp, &fold->res);
	tcf_exts_get_net(&fold->exts);
	tcf_queue_work(&fold->rwork, route4_delete_filter_work);
}

So my patch simply eliminates the handle judgement and it seems to work fine on syzbot.
If I misunderstood anything, pleaese let me know :)   Thanks!

      reply	other threads:[~2022-06-15 11:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-04 16:46 syzbot
2022-06-14 14:35 ` Zhen Chen
2022-06-14 14:46   ` Dan Carpenter
2022-06-15 11:57     ` Zhen Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=786e43b7-fe00-ffde-ed9a-f47a695c4123@huawei.com \
    --to=chenzhen126@huawei.com \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rose.chen@huawei.com \
    --cc=syzbot+2e3efb5eb71cb5075ba7@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=xiyou.wangcong@gmail.com \
    --subject='Re: [syzbot] WARNING: ODEBUG bug in route4_destroy' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).