Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: luoj@codeaurora.org
To: Rob Herring <robh+dt@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	"Gross, Andy" <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Robert Marko <robert.marko@sartura.hr>,
	netdev <netdev@vger.kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	devicetree@vger.kernel.org, Sricharan <sricharan@codeaurora.org>
Subject: Re: [PATCH 3/3] dt-bindings: net: rename Qualcomm IPQ MDIO bindings
Date: Mon, 02 Aug 2021 15:19:48 +0800	[thread overview]
Message-ID: <7873e70dcf4fe749521bd9c985571742@codeaurora.org> (raw)
In-Reply-To: <CAL_Jsq+=Vyy7_EQ_A7JW4ZfqpPU=6eCyUYMnPORChGvefw-yTA@mail.gmail.com>

On 2021-07-30 01:29, Rob Herring wrote:
> On Thu, Jul 29, 2021 at 6:54 AM Luo Jie <luoj@codeaurora.org> wrote:
>> 
>> rename ipq4019-mdio.yaml to ipq-mdio.yaml for supporting more
>> ipq boards such as ipq40xx, ipq807x, ipq60xx and ipq50xx.
>> 
>> Signed-off-by: Luo Jie <luoj@codeaurora.org>
>> ---
>>  ...m,ipq4019-mdio.yaml => qcom,ipq-mdio.yaml} | 32 
>> ++++++++++++++++---
>>  1 file changed, 28 insertions(+), 4 deletions(-)
>>  rename Documentation/devicetree/bindings/net/{qcom,ipq4019-mdio.yaml 
>> => qcom,ipq-mdio.yaml} (58%)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml 
>> b/Documentation/devicetree/bindings/net/qcom,ipq-mdio.yaml
>> similarity index 58%
>> rename from 
>> Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
>> rename to Documentation/devicetree/bindings/net/qcom,ipq-mdio.yaml
>> index 0c973310ada0..5bdeb461523b 100644
>> --- a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
>> +++ b/Documentation/devicetree/bindings/net/qcom,ipq-mdio.yaml
>> @@ -1,10 +1,10 @@
>>  # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>  %YAML 1.2
>>  ---
>> -$id: http://devicetree.org/schemas/net/qcom,ipq4019-mdio.yaml#
>> +$id: http://devicetree.org/schemas/net/qcom,ipq-mdio.yaml#
>>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>> 
>> -title: Qualcomm IPQ40xx MDIO Controller Device Tree Bindings
>> +title: Qualcomm IPQ MDIO Controller Device Tree Bindings
>> 
>>  maintainers:
>>    - Robert Marko <robert.marko@sartura.hr>
>> @@ -14,7 +14,9 @@ allOf:
>> 
>>  properties:
>>    compatible:
>> -    const: qcom,ipq4019-mdio
>> +    oneOf:
>> +      - const: qcom,ipq4019-mdio
>> +      - const: qcom,ipq-mdio
> 
> This is more than the commit log suggests. A generic compatible by
> itself is not sufficient. If other chips have the same block, just use
> 'qcom,ipq4019-mdio'. They should also have a compatible for the new
> SoC in case it's not 'the same'.
> 
> Also, use 'enum' rather than oneOf plus const.
> 
> Hi Rob
> Thanks for the comments, will keep the compatible "qcom,ipq4019-mdio" 
> unchanged,
> and add the new compatible name by using 'enum' in the next patch set.
> the commit log will be updated in the next patch set.
>> 
>>    "#address-cells":
>>      const: 1
>> @@ -23,7 +25,29 @@ properties:
>>      const: 0
>> 
>>    reg:
>> -    maxItems: 1
>> +    maxItems: 2
> 
> This breaks compatibility because now 1 entry is not valid.
> 
> will update it by using "minItems: 1, maxItems: 2" in the next patch 
> set.
> 
>> +
>> +  clocks:
>> +    items:
>> +      - description: MDIO clock
>> +
>> +  clock-names:
>> +    items:
>> +      - const: gcc_mdio_ahb_clk
>> +
>> +  resets:
>> +    items:
>> +      - description: MDIO reset & GEPHY hardware reset
>> +
>> +  reset-names:
>> +    items:
>> +      - const: gephy_mdc_rst
> 
> These all now apply to 'qcom,ipq4019-mdio'. The h/w had no clocks or
> resets and now does?
> 
> You don't need *-names when there is only 1.
> 
> Hi Rob
> thanks for the comment, clocks is for configuring the source clock of 
> MDIO bus,
> which is apply to ipq4019 and the new chip set such as ipq807x, ipq50xx 
> and ipq60xx,
> which is not configured because of uboot configuring it, kernel should 
> not depends on
> the configuration of uboot, so i add it.
> will remove the *-name in the next patch set.
> 
>> +  phy-reset-gpios:
>> +    maxItems: 3
>> +    description:
>> +      The phandle and specifier for the GPIO that controls the RESET
>> +      lines of PHY devices on that MDIO bus.
> 
> This belongs in the phy node since the reset is connected to the phy.
> 
> since the phylib code can't satisfy resetting PHY in IPQ chipset, 
> phylib resets phy by
> configuring GPIO output value to 1, then to 0. however the PHY reset in 
> IPQ chipset need
> to configuring GPIO output value to 0, then to 1 for the PHY reset, so 
> i put the phy-reset-gpios here.
> 
>> 
>>  required:
>>    - compatible
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
>> Forum,
>> a Linux Foundation Collaborative Project
>> 

  reply	other threads:[~2021-08-02  7:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29 12:53 [PATCH 1/3] net: mdio-ipq4019: Add mdio reset function Luo Jie
2021-07-29 12:53 ` [PATCH 2/3] net: mdio-ipq4019: rename mdio_ipq4019 to mdio_ipq Luo Jie
2021-07-29 13:15   ` Andrew Lunn
2021-08-02  5:56     ` luoj
2021-07-29 12:53 ` [PATCH 3/3] dt-bindings: net: rename Qualcomm IPQ MDIO bindings Luo Jie
2021-07-29 13:17   ` Andrew Lunn
2021-08-02  6:02     ` luoj
2021-07-29 13:57   ` Rob Herring
2021-07-29 17:29   ` Rob Herring
2021-08-02  7:19     ` luoj [this message]
2021-08-02 13:39       ` Andrew Lunn
2021-08-04  2:37         ` Jie Luo
2021-07-29 13:26 ` [PATCH 1/3] net: mdio-ipq4019: Add mdio reset function Andrew Lunn
2021-08-02  6:46   ` luoj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7873e70dcf4fe749521bd9c985571742@codeaurora.org \
    --to=luoj@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=bjorn.andersson@linaro.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robert.marko@sartura.hr \
    --cc=robh+dt@kernel.org \
    --cc=sricharan@codeaurora.org \
    --subject='Re: [PATCH 3/3] dt-bindings: net: rename Qualcomm IPQ MDIO bindings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox