Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jun Miao <jun.miao@windriver.com>, 3chas3@gmail.com
Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [V2][PATCH] atm: horizon: Fix spelling mistakes in TX comment
Date: Sat, 07 Aug 2021 09:58:14 -0700 [thread overview]
Message-ID: <7afa073ece002f84f4f2c28b3ac3032ded94bf43.camel@perches.com> (raw)
In-Reply-To: <20210807153830.1293760-1-jun.miao@windriver.com>
On Sat, 2021-08-07 at 23:38 +0800, Jun Miao wrote:
> It's "must not", not "musn't", meaning "shall not".
> Let's fix that.
>
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Jun Miao <jun.miao@windriver.com>
> ---
> drivers/atm/horizon.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
> index 4f2951cbe69c..9ee494bc5c51 100644
> --- a/drivers/atm/horizon.c
> +++ b/drivers/atm/horizon.c
> @@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc)
>
>
> // Part of the job is done by atm_pcr_goal which gives us a PCR
> // specification which says: EITHER grab the maximum available PCR
> - // (and perhaps a lower bound which we musn't pass), OR grab this
> + // (and perhaps a lower bound which we mustn't pass), OR grab this
I meant to suggest you change the patch to use "must not" not
the commit message.
> // amount, rounding down if you have to (and perhaps a lower bound
> - // which we musn't pass) OR grab this amount, rounding up if you
> - // have to (and perhaps an upper bound which we musn't pass). If any
> + // which we mustn't pass) OR grab this amount, rounding up if you
> + // have to (and perhaps an upper bound which we mustn't pass). If any
> // bounds ARE passed we fail. Note that rounding is only rounding to
> // match device limitations, we do not round down to satisfy
> // bandwidth availability even if this would not violate any given
next prev parent reply other threads:[~2021-08-07 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 15:38 Jun Miao
2021-08-07 16:58 ` Joe Perches [this message]
2021-08-07 23:33 ` Jun Miao
2021-08-07 15:41 Jun Miao
2021-08-08 12:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7afa073ece002f84f4f2c28b3ac3032ded94bf43.camel@perches.com \
--to=joe@perches.com \
--cc=3chas3@gmail.com \
--cc=jun.miao@windriver.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--subject='Re: [V2][PATCH] atm: horizon: Fix spelling mistakes in TX comment' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).