Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vadim Fedorenko <vfedorenko@novek.ru>
To: Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Xin Long <lucien.xin@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net 1/3] udp: check for encap using encap_enable
Date: Mon, 12 Jul 2021 15:13:10 +0100 [thread overview]
Message-ID: <7da0e1e0-7814-4179-ba04-d578b380fd8a@novek.ru> (raw)
In-Reply-To: <970fa58decaef6c86db206c00d6c7ab6582b45d3.camel@redhat.com>
On 12.07.2021 15:05, Paolo Abeni wrote:
> On Mon, 2021-07-12 at 13:32 +0100, Vadim Fedorenko wrote:
>> On 12.07.2021 09:37, Paolo Abeni wrote:
>>>> Fixes: 60fb9567bf30 ("udp: implement complete book-keeping for encap_needed")
>>>
>>> IMHO this not fix. Which bug are you observing that is addressed here?
>>>
>> I thought that introduction of encap_enabled should go further to switch the
>> code to check this particular flag and leave encap_type as a description of
>> specific type (or subtype) of used encapsulation.
>
> Than to me it looks more like a refactor than a fix. Is this strictly
> needed by the following patch? if not, I suggest to consider net-next
> as a target for this patch, or even better, drop it altogether.
>
Looks like it isn't strictly needed for the following patch. Do you think that
such refactor would lead to more harm than benefits provided by clearness of
usage of encap_enable and encap_type fields? I mean why do you think that it's
better to drop it?
Thanks!
next prev parent reply other threads:[~2021-07-12 14:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 0:55 [PATCH net 0/3] Fix PMTU for ESP-in-UDP encapsulation Vadim Fedorenko
2021-07-12 0:55 ` [PATCH net 1/3] udp: check for encap using encap_enable Vadim Fedorenko
2021-07-12 8:37 ` Paolo Abeni
2021-07-12 12:32 ` Vadim Fedorenko
2021-07-12 14:05 ` Paolo Abeni
2021-07-12 14:13 ` Vadim Fedorenko [this message]
2021-07-12 14:33 ` Paolo Abeni
2021-07-12 16:27 ` Vadim Fedorenko
2021-07-12 0:55 ` [PATCH net 2/3] udp: check encap socket in __udp_lib_err Vadim Fedorenko
2021-07-12 7:59 ` Willem de Bruijn
2021-07-12 12:09 ` Vadim Fedorenko
2021-07-12 9:07 ` Paolo Abeni
2021-07-12 12:45 ` Vadim Fedorenko
2021-07-12 13:37 ` Paolo Abeni
2021-07-12 14:05 ` Vadim Fedorenko
2021-07-12 14:09 ` Paolo Abeni
2021-07-16 17:50 ` Xin Long
2021-07-12 0:55 ` [PATCH net 3/3] selftests: net: add ESP-in-UDP PMTU test Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7da0e1e0-7814-4179-ba04-d578b380fd8a@novek.ru \
--to=vfedorenko@novek.ru \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
--subject='Re: [PATCH net 1/3] udp: check for encap using encap_enable' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).