Netdev Archive on
help / color / mirror / Atom feed
From: Mat Martineau <>
To: Jakub Kicinski <>
Cc:, Geliang Tang <>,,,
Subject: Re: [PATCH net] mptcp: drop unused rcu member in mptcp_pm_addr_entry
Date: Tue, 3 Aug 2021 11:11:16 -0700 (PDT)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, 3 Aug 2021, Jakub Kicinski wrote:

> On Mon,  2 Aug 2021 16:19:14 -0700 Mat Martineau wrote:
>> From: Geliang Tang <>
>> kfree_rcu() had been removed from pm_netlink.c, so this rcu field in
>> struct mptcp_pm_addr_entry became useless. Let's drop it.
>> Fixes: 1729cf186d8a ("mptcp: create the listening socket for new port")
>> Signed-off-by: Geliang Tang <>
>> Signed-off-by: Mat Martineau <>
> This just removes a superfluous member, right? So could as well be
> applied to net-next?

Hi Jakub -

Yes, it's just a superfluous member.

It seemed like a -net candidate, as it was addressing a mistake in a 
previous commit (rather than a feature or refactor) and does affect memory 
usage - and I was trying to be mindful of the stable tree process. But the 
patch will apply cleanly to either net or net-next, so you could apply to 
net-next if the fix is not significant enough.

I'll tune my net-vs-net-next threshold based on the tree I see it applied 
to :)


Mat Martineau

  reply	other threads:[~2021-08-03 18:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 23:19 Mat Martineau
2021-08-03 15:21 ` Jakub Kicinski
2021-08-03 18:11   ` Mat Martineau [this message]
2021-08-03 21:28     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH net] mptcp: drop unused rcu member in mptcp_pm_addr_entry' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).