Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Justin Iurman <justin.iurman@uliege.be>, netdev@vger.kernel.org
Cc: stephen@networkplumber.org
Subject: Re: [PATCH iproute2-next v2 2/3] New IOAM6 encap type for routes
Date: Wed, 28 Jul 2021 20:44:57 -0600	[thread overview]
Message-ID: <81516751-ece9-2d29-023b-b0fba34eb0fe@gmail.com> (raw)
In-Reply-To: <1187403794.27040801.1627393327692.JavaMail.zimbra@uliege.be>

On 7/27/21 7:42 AM, Justin Iurman wrote:
>> +	trace = RTA_DATA(tb[IOAM6_IPTUNNEL_TRACE]);
>> +
>> +	print_hex(PRINT_ANY, "type", "type %#06x ", ntohl(trace->type_be32) >> 8);
> Uh oh... Should be %#08x instead, sorry for that. Should I submit a v3 to reflect it?
> 
>> +	print_uint(PRINT_ANY, "ns", "ns %u ", ntohs(trace->namespace_id));
>> +	print_uint(PRINT_ANY, "size", "size %u ", trace->remlen * 4);
>> +}
>> +

roll it into v3.

(also, please chop unrelated content in the reply; it is easy to miss
that one line comment scrolling the long message)

  reply	other threads:[~2021-07-29  2:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-24 17:21 [PATCH iproute2-next v2 0/3] Provide support for IOAM Justin Iurman
2021-07-24 17:21 ` [PATCH iproute2-next v2 1/3] Add, show, link, remove IOAM namespaces and schemas Justin Iurman
2021-07-29  2:41   ` David Ahern
2021-07-29  9:51     ` Justin Iurman
2021-07-29 14:32       ` David Ahern
2021-07-29 16:41         ` Justin Iurman
2021-07-30 14:39           ` David Ahern
2021-08-11  3:47             ` Stephen Hemminger
2021-08-11  3:46   ` Stephen Hemminger
2021-07-24 17:21 ` [PATCH iproute2-next v2 2/3] New IOAM6 encap type for routes Justin Iurman
2021-07-27 13:42   ` Justin Iurman
2021-07-29  2:44     ` David Ahern [this message]
2021-07-24 17:21 ` [PATCH iproute2-next v2 3/3] IOAM man8 Justin Iurman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81516751-ece9-2d29-023b-b0fba34eb0fe@gmail.com \
    --to=dsahern@gmail.com \
    --cc=justin.iurman@uliege.be \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --subject='Re: [PATCH iproute2-next v2 2/3] New IOAM6 encap type for routes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).