Netdev Archive on
help / color / mirror / Atom feed
From: Thomas Gleixner <>
To: Shung-Hsi Yu <>,,,,
Cc: Peter Zijlstra <>,
	Jesse Brandeburg <>,
	Nitesh Lal <>
Subject: Re: [RFC] genirq: Add effective CPU index retrieving interface
Date: Tue, 10 Aug 2021 16:12:53 +0200	[thread overview]
Message-ID: <874kbxs80q.ffs@tglx> (raw)
In-Reply-To: <YL3LrgAzMNI2hp5i@syu-laptop>

On Mon, Jun 07 2021 at 15:33, Shung-Hsi Yu wrote:
> Most driver's IRQ spreading scheme is naive compared to the IRQ spreading
> scheme introduced since IRQ subsystem rework, so it better to rely
> request_irq() to spread IRQ out.
> However, drivers that care about performance enough also tends to try
> allocating memory on the same NUMA node on which the IRQ handler will run.
> For such driver to rely on request_irq() for IRQ spreading, we also need to
> provide an interface to retrieve the CPU index after calling
> request_irq().

So if you are interested in the resulting NUMA node, then why exposing a
random CPU out of the affinity mask instead of exposing a function to
retrieve the NUMA node?
> +/**
> + * irq_get_effective_cpu - Retrieve the effective CPU index
> + * @irq:	Target interrupt to retrieve effective CPU index
> + *
> + * When the effective affinity cpumask has multiple CPU toggled, it just
> + * returns the first CPU in the cpumask.
> + */
> +int irq_get_effective_cpu(unsigned int irq)
> +{
> +	struct irq_data *data = irq_get_irq_data(irq);

This can be NULL.

> +	struct cpumask *m;
> +
> +	m = irq_data_get_effective_affinity_mask(data);
> +	return cpumask_first(m);
> +}



  reply	other threads:[~2021-08-10 14:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07  7:33 [RFC] genirq: Add effective CPU index retrieving interface Shung-Hsi Yu
2021-08-10 14:12 ` Thomas Gleixner [this message]
2021-08-10 14:35   ` Nitesh Lal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kbxs80q.ffs@tglx \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).