Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kurt Kanzenbach <kurt@linutronix.de>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Richard Cochran <richardcochran@gmail.com>,
Kamil Alkhouri <kamil.alkhouri@hs-offenburg.de>,
ilias.apalodimas@linaro.org
Subject: Re: [PATCH v3 5/8] net: dsa: hellcreek: Add TAPRIO offloading support
Date: Tue, 25 Aug 2020 11:42:02 +0200 [thread overview]
Message-ID: <875z9712qd.fsf@kurt> (raw)
In-Reply-To: <87y2m3txox.fsf@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1526 bytes --]
On Mon Aug 24 2020, Vinicius Costa Gomes wrote:
> Hi Kurt,
>
> Kurt Kanzenbach <kurt@linutronix.de> writes:
>
>>>> +static void hellcreek_setup_tc_mapping(struct hellcreek *hellcreek,
>>>> + struct net_device *netdev)
>>>> +{
>>>> + int i, j;
>>>> +
>>>> + /* Setup mapping between traffic classes and port queues. */
>>>> + for (i = 0; i < netdev_get_num_tc(netdev); ++i) {
>>>> + for (j = 0; j < netdev->tc_to_txq[i].count; ++j) {
>>>> + const int queue = j + netdev->tc_to_txq[i].offset;
>>>> +
>>>> + hellcreek_select_prio(hellcreek, i);
>>>> + hellcreek_write(hellcreek,
>>>> + queue << HR_PRTCCFG_PCP_TC_MAP_SHIFT,
>>>> + HR_PRTCCFG);
>>>> + }
>>>> + }
>>>> +}
>>>
>>> What other driver have you seen that does this?
>>>
>>
>> Probably none.
>>
>> With TAPRIO traffic classes and the mapping to queues can be
>> configured. The switch can also map traffic classes. That sounded like a
>> good match to me.
>
> The only reason I could think that you would need this that *right now*
> taprio has pretty glaring oversight: that in the offload parameters each entry
> 'gate_mask' reference the "Traffic Class" (i.e. bit 0 is Traffic Class
> 0), and it really should be the HW queue.
>
> I have a patch that does the conversion on taprio before talking to the
> driver. Do you think it would help you avoid doing this on the driver
> side?
I think so. As Vladimir pointed out, the driver should setup an identity
mapping which I already did by default.
Can you point me your patch?
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-08-25 9:42 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 8:11 [PATCH v3 0/8] Hirschmann Hellcreek DSA driver Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 1/8] net: dsa: Add tag handling for Hirschmann Hellcreek switches Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 2/8] net: dsa: Add DSA driver " Kurt Kanzenbach
2020-08-24 22:44 ` Andrew Lunn
2020-08-25 9:07 ` Kurt Kanzenbach
2020-08-25 13:56 ` Andrew Lunn
2020-08-25 14:48 ` Kurt Kanzenbach
2020-08-27 10:29 ` Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 3/8] net: dsa: hellcreek: Add PTP clock support Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 4/8] net: dsa: hellcreek: Add support for hardware timestamping Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 5/8] net: dsa: hellcreek: Add TAPRIO offloading support Kurt Kanzenbach
2020-08-22 14:39 ` Vladimir Oltean
2020-08-24 6:10 ` Kurt Kanzenbach
2020-08-24 23:45 ` Vinicius Costa Gomes
2020-08-25 9:42 ` Kurt Kanzenbach [this message]
2020-08-25 17:58 ` Vinicius Costa Gomes
2020-08-27 10:12 ` Kurt Kanzenbach
2020-08-25 9:46 ` Vladimir Oltean
2020-08-25 10:09 ` Kurt Kanzenbach
2020-08-25 17:33 ` Vinicius Costa Gomes
2020-08-24 22:56 ` Vladimir Oltean
2020-08-25 9:33 ` Kurt Kanzenbach
2020-08-25 9:38 ` Vladimir Oltean
2020-08-25 9:55 ` Kurt Kanzenbach
2020-08-27 16:25 ` Richard Cochran
2020-08-28 12:31 ` Kurt Kanzenbach
2020-08-24 23:57 ` Vinicius Costa Gomes
2020-08-25 9:23 ` Kurt Kanzenbach
2020-08-25 9:32 ` Vladimir Oltean
2020-09-01 14:20 ` Kurt Kanzenbach
2020-09-01 14:47 ` Vladimir Oltean
2020-08-25 17:50 ` Vinicius Costa Gomes
2020-08-20 8:11 ` [PATCH v3 6/8] net: dsa: hellcreek: Add PTP status LEDs Kurt Kanzenbach
2020-08-24 22:50 ` Andrew Lunn
2020-08-20 8:11 ` [PATCH v3 7/8] dt-bindings: Add vendor prefix for Hirschmann Kurt Kanzenbach
2020-08-20 8:11 ` [PATCH v3 8/8] dt-bindings: net: dsa: Add documentation for Hellcreek switches Kurt Kanzenbach
2020-08-24 22:52 ` Andrew Lunn
2020-08-25 22:28 ` Rob Herring
2020-08-24 21:31 ` [PATCH v3 0/8] Hirschmann Hellcreek DSA driver Jakub Kicinski
2020-08-24 22:02 ` Vladimir Oltean
2020-08-24 22:35 ` David Miller
2020-08-24 22:57 ` Vladimir Oltean
2020-08-25 11:21 ` Kurt Kanzenbach
2020-08-25 17:14 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z9712qd.fsf@kurt \
--to=kurt@linutronix.de \
--cc=andrew@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=kamil.alkhouri@hs-offenburg.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vinicius.gomes@intel.com \
--cc=vivien.didelot@gmail.com \
--subject='Re: [PATCH v3 5/8] net: dsa: hellcreek: Add TAPRIO offloading support' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).