From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB6B1C433E1 for ; Wed, 19 Aug 2020 06:00:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 931F420738 for ; Wed, 19 Aug 2020 06:00:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ImtWz7KS"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="l0HKVQhx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726531AbgHSGA6 (ORCPT ); Wed, 19 Aug 2020 02:00:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbgHSGA6 (ORCPT ); Wed, 19 Aug 2020 02:00:58 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A19CC061389 for ; Tue, 18 Aug 2020 23:00:57 -0700 (PDT) From: Kurt Kanzenbach DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1597816855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Su9AzmrEvGIiIk6KMVGf8fs5CVs2iz8ru9IP2bPyigA=; b=ImtWz7KSODD9QE3kf9T2FsMIradLZ9p63SwQXNCDgxTb2fNbUZOXX/7KcLvtZOOC7yip1p tAkT9D13FvF//Jl1o83VhFPq6VQBxzVlxJqcCyG2VucPFDLqik3N5bVomFSSaCE9BWQ8kz 3G1E6SCW/dNXKOSAlNbf/WrFGua+MWp6ruXZAxPky6zy3+XgBjvxTGFOQt1kxFa0JCODrF da89FjhbcvFYM+RBRPlUjI1ueIISUR9GsCl+Y6/tFePuEnkE2wzY5imEBV+4KKlKp7Pqzg U9Xv+WQaMp6BGrS66nMbaga9Sfsq5MTPwFItZPitOz7ra1Pj1aZ9Q1CuAPSjUA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1597816855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Su9AzmrEvGIiIk6KMVGf8fs5CVs2iz8ru9IP2bPyigA=; b=l0HKVQhxOus3pQYxX5lGYwI80S+j7XhUcXRhwD1eLuFo77+lTOFpiN8IaTN+2tFleUcqLu kDQ7slKrKgZTJBAQ== To: Russell King - ARM Linux admin Cc: Richard Cochran , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Jiri Pirko , Ido Schimmel , Heiner Kallweit , Grygorii Strashko , Samuel Zou , netdev@vger.kernel.org, Petr Machata , Sebastian Andrzej Siewior Subject: Re: [PATCH v4 3/9] net: dsa: mv88e6xxx: Use generic helper function In-Reply-To: <20200818104305.GB1551@shell.armlinux.org.uk> References: <20200818103251.20421-1-kurt@linutronix.de> <20200818103251.20421-4-kurt@linutronix.de> <20200818104305.GB1551@shell.armlinux.org.uk> Date: Wed, 19 Aug 2020 08:00:54 +0200 Message-ID: <87imdfb2eh.fsf@kurt> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue Aug 18 2020, Russell King - ARM Linux admin wrote: > On Tue, Aug 18, 2020 at 12:32:45PM +0200, Kurt Kanzenbach wrote: >> -static int is_pdelay_resp(u8 *msgtype) >> +static int is_pdelay_resp(const struct ptp_header *hdr) >> { >> - return (*msgtype & 0xf) =3D=3D 3; >> + return (hdr->tsmt & 0xf) =3D=3D 3; > > Forgive my ignorance about PTPv1, but does PTPv1 have these as well? pdelay is PTP v2 specific.=20 > Is there a reason not to use the helper introduced in patch 2 here? Yes, it doesn't have to be. This driver only deals with PTP v2. > Should we have definitions for the message types? That is something one can think of. At the moment there are not many users though. Thanks, Kurt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEooWgvezyxHPhdEojeSpbgcuY8KYFAl88wBYACgkQeSpbgcuY 8Ka63BAA1qjU8ZbyxLNimAvI2wOCwKlgyP0jQs6dWFCEgXhC2whZAaGSvD9X9HQL kI5pxd3a4RVK6QjDqMU+uvhbD3deDaJ1XC5Niku2iE7TLCbC3Aos/c7RjEKRNXWk iRLlCKHnnLHXALHpVTet9Yi1GlkmRusARzkQXynYP1iH7WZfRknqsQUzuPU2X8fC dcoHd/JaJXf6nuhrzlQfMGIJhx2humhPO5807ELtnBmN91gXenjyxMYIFEj5LP1E BwcTDZl85UpZ6aNutkToz5e9la8UjEHM5ACZO45EqPGM/XvNtwQp0lMMkT5/4VrE SLlbhz0pOX9AqRFz5sYgG2E7TM1jXxTYDN/u9awPqBsoyoaL+ARHzsb9Uw2G9rGW QzGxwIFDa46SDNAX1934kJ4qJRYyVwPAKCg43UFxsjnvjomNVP6C+X10gzXoCAEn AiNdr/s4Ap6JMUWMC40e4i83HiSQzRJni67bwVNiBLAbQHofi9LBK8F+WQPhMY/Y 02XyiLSLADN4omFO+qXqyVEtO11RVs78OvX3oNpMQoGg2eI6BLO8qQKSoHswtVs0 9wPeXvOQQvwOvyl3KPn4atvK8tBKDMciffUNzYBt6J1zPmNZnD1WfYaub/eOQgfn 5VgFXeIYL6AGoEP1Xl/njwGBR9vAOYAJR0a1zQfcK7zniKB88WE= =4oYX -----END PGP SIGNATURE----- --=-=-=--