Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kurt Kanzenbach <kurt@linutronix.de>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
	Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	bridge@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH] net: bridge: Don't reset time stamps on SO_TXTIME enabled sockets
Date: Fri, 21 Aug 2020 09:47:25 +0200	[thread overview]
Message-ID: <87mu2oe8z6.fsf@kurt> (raw)
In-Reply-To: <5affe98d-bb16-0744-5266-db708fb9dc16@cumulusnetworks.com>

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

On Thu Aug 20 2020, Nikolay Aleksandrov wrote:
> The new conditionals will be for all forwarded packets, not only the
> ones that are transmitted through the bridge master device.

I see makes sense.

> If you'd like to do this please limit it to the bridge dev transmit.

I'm wondering how to do that. The problem is that the time stamp is
reset to zero unconditionally in br_forward_finish(). This function is
also called in the transmit path.

Thanks,
Kurt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

      reply	other threads:[~2020-08-21  7:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20 10:57 Kurt Kanzenbach
2020-08-20 11:23 ` Nikolay Aleksandrov
2020-08-21  7:47   ` Kurt Kanzenbach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mu2oe8z6.fsf@kurt \
    --to=kurt@linutronix.de \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    --subject='Re: [RFC PATCH] net: bridge: Don'\''t reset time stamps on SO_TXTIME enabled sockets' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).