Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: subashab@codeaurora.org
Cc: Daniele Palmas <dnlplm@gmail.com>,
	Aleksander Morgado <aleksander@aleksander.es>,
	Network Development <netdev@vger.kernel.org>,
	Sean Tranchetti <stranche@codeaurora.org>
Subject: Re: RMNET QMAP data aggregation with size greater than 16384
Date: Fri, 13 Aug 2021 08:25:14 +0200	[thread overview]
Message-ID: <87tujtamk5.fsf@miraculix.mork.no> (raw)
In-Reply-To: <7aac9ee90376e4757e5f2ebc4948ebed@codeaurora.org> (subashab@codeaurora.org's message of "Fri, 13 Aug 2021 00:21:21 -0600")

subashab@codeaurora.org writes:

>> Just an heads-up that when I proposed that urb size there were doubts
>> about the value (see
>> https://patchwork.ozlabs.org/project/netdev/patch/20200909091302.20992-1-dnlplm@gmail.com/#2523774
>> and
>> https://patchwork.ozlabs.org/project/netdev/patch/20200909091302.20992-1-dnlplm@gmail.com/#2523958):
>> it is true that this time you are setting the size just when qmap is
>> enabled, but I think that Carl's comment about low-cat chipsets could
>> still apply.
>> Thanks,
>> Daniele
>> 
>
> Thanks for bringing this up.
>
> Looks like a tunable would be needed to satisfy all users.
> Perhaps we can use 32k as default in mux and passthrough mode but
> allow for changes
> there if needed through a sysfs.

Sounds reasonable to me.



Bjørn

  reply	other threads:[~2021-08-13  6:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31 22:45 RMNET QMAP data aggregation with size greater than 16384 Aleksander Morgado
2021-08-05 19:10 ` subashab
2021-08-05 20:32   ` Aleksander Morgado
     [not found]     ` <CAGRyCJHYkH4_FvTzk7BFwjMN=iOTN_Y2=4ueY=s3rJMQO9j7uw@mail.gmail.com>
2021-08-05 21:01       ` Aleksander Morgado
2021-08-05 21:12         ` Daniele Palmas
2021-08-05 22:57     ` subashab
2021-08-06 14:08       ` Aleksander Morgado
2021-08-06 18:42         ` subashab
2021-08-06 19:58           ` Bjørn Mork
2021-08-06 20:22             ` Aleksander Morgado
2021-08-06 22:30               ` subashab
2021-08-07 10:55                 ` Bjørn Mork
2021-08-09 21:40                   ` subashab
2021-08-12 12:02                     ` Daniele Palmas
2021-08-13  6:21                       ` subashab
2021-08-13  6:25                         ` Bjørn Mork [this message]
2021-09-03 13:55                           ` Daniele Palmas
2021-09-08  6:21                             ` subashab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tujtamk5.fsf@miraculix.mork.no \
    --to=bjorn@mork.no \
    --cc=aleksander@aleksander.es \
    --cc=dnlplm@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stranche@codeaurora.org \
    --cc=subashab@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).