Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Steve Bennett <steveb@workware.net.au>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
	davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH v2] net: phy: micrel: Fix detection of ksz87xx switch
Date: Sat, 31 Jul 2021 01:08:21 +0200	[thread overview]
Message-ID: <932a0c80-db3c-77ac-6bbe-101804329e02@denx.de> (raw)
In-Reply-To: <20210730225750.98849-1-steveb@workware.net.au>

On 7/31/21 12:57 AM, Steve Bennett wrote:
> The logic for discerning between KSZ8051 and KSZ87XX PHYs is incorrect
> such that the that KSZ87XX switch is not identified correctly.
> 
> ksz8051_ksz8795_match_phy_device() uses the parameter ksz_phy_id
> to discriminate whether it was called from ksz8051_match_phy_device()
> or from ksz8795_match_phy_device() but since PHY_ID_KSZ87XX is the
> same value as PHY_ID_KSZ8051, this doesn't work.
> 
> Instead use a bool to discriminate the caller.
> 
> Without this patch, the KSZ8795 switch port identifies as:
> 
> ksz8795-switch spi3.1 ade1 (uninitialized): PHY [dsa-0.1:03] driver [Generic PHY]
> 
> With the patch, it identifies correctly:
> 
> ksz8795-switch spi3.1 ade1 (uninitialized): PHY [dsa-0.1:03] driver [Micrel KSZ87XX Switch]
> 
> Fixes: 8b95599c55ed24b36cf4 ("net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs")
> Signed-off-by: Steve Bennett <steveb@workware.net.au>

Looks obviously correct to me, and yes, this reinstates behavior before 
V3 of the original patch. Thanks!

Reviewed-by: Marek Vasut <marex@denx.de>

  reply	other threads:[~2021-07-30 23:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 10:51 [PATCH] " Steve Bennett
2021-07-30 16:59 ` Jakub Kicinski
2021-07-30 22:19   ` Steve Bennett
2021-08-07  0:01     ` Ben Hutchings
2021-08-07  0:06       ` [PATCH net] net: phy: micrel: Fix link detection on ksz87xx switch" Ben Hutchings
2021-08-08 11:10         ` patchwork-bot+netdevbpf
2021-08-08 22:18       ` [PATCH] net: phy: micrel: Fix detection of ksz87xx switch Steve Bennett
2021-07-30 22:57 ` [PATCH v2] " Steve Bennett
2021-07-30 23:08   ` Marek Vasut [this message]
2021-08-02 14:10   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=932a0c80-db3c-77ac-6bbe-101804329e02@denx.de \
    --to=marex@denx.de \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=steveb@workware.net.au \
    --subject='Re: [PATCH v2] net: phy: micrel: Fix detection of ksz87xx switch' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).